Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vale to latest #155

Closed
wants to merge 6 commits into from
Closed

Update Vale to latest #155

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f8036c
Update Vale to latest
dennisameling Sep 14, 2023
f1acb25
Forgot to commit Dockerfile
dennisameling Sep 14, 2023
c706533
Bump Python to 3.11
dennisameling Sep 14, 2023
fba2172
Bump esbonio and rstcheck to latest
dennisameling Sep 14, 2023
4b238b4
Fix rstcheck invocation
dennisameling Sep 14, 2023
7a02eca
Merge branch 'main' into update-vale-to-latest
RCheesley Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: errata-ai/vale-action@reviewdog
with:
# Please keep version in sync with the version in .gitpod.Dockerfile for a consistent experience
version: 2.20.2
version: 2.28.3
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
5 changes: 2 additions & 3 deletions .gitpod.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
FROM python:3.10
FROM python:3.11

# Don't update to a higher version until this issue has been fixed: https://github.com/errata-ai/vale/issues/528
# Please keep version in sync with the version in .github/workflows/linting.yml for a consistent experience
ENV VALE_VERSION=2.20.2
ENV VALE_VERSION=2.28.3

WORKDIR /workspace

Expand Down
3 changes: 2 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"esbonio.sphinx.confDir": "${workspaceFolder}/docs",
"restructuredtext.pythonRecommendation.disabled": true,
"restructuredtext.preview.name": "sphinx",
"gitlens.showWhatsNewAfterUpgrades": false
"gitlens.showWhatsNewAfterUpgrades": false,
"restructuredtext.linter.rstcheck.executablePath": "rstcheck"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the rstcheck vscode integration. Source: vscode-restructuredtext/vscode-restructuredtext#400 (comment)

However, the maintainers mention that rstcheck shouldn't be necessary anymore as Esbonio reports most of the issues too: vscode-restructuredtext/vscode-restructuredtext#400 (comment). I'm happy to remove it altogether but Esbonio certainly doesn't catch everything yet.

}
4 changes: 2 additions & 2 deletions docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
sphinx==6.2.1
sphinx_rtd_theme==1.2.0
readthedocs-sphinx-search==0.3.1
rstcheck==6.1.1
rstcheck==6.2.0
myst-parser==1.0.0
linkify-it-py==2.0.0
esbonio==0.15.0
esbonio==0.16.1
attrs==22.2.0