Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Remove font assignment to elements in vizro-bootstrap #755

Merged
merged 14 commits into from
Oct 2, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Sep 30, 2024

Description

  • Update HF links to show app in full height/width view

  • Removal of font-styling for elements p, label, ul, li, blockquote and a- based on this PR: https://github.com/McK-Private/vizro-bootstrap/pull/32

  • These previously defined properties now lead to differences in the screenshots - decided to remove them and update all screenshots given that the QB design library doesn't assign any styling to elements either: https://github.com/mckinsey/vizro-qa/pull/122

    ```
    letter-spacing: -0.112px;
    line-height: 16px;
    ```
    

Result: Elements will have no font-styling attached and will inherit anything their parent has.

Would like a review mostly from @pruthvip15 and then another codeowner so we can merge 👍

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen changed the title [Draft] Test out removal of font assignment to elements [Tidy] Removal of font assignment to elements in vizro-bootstrap Sep 30, 2024
@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Sep 30, 2024
@huong-li-nguyen huong-li-nguyen removed the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Oct 1, 2024
@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Oct 1, 2024
@huong-li-nguyen huong-li-nguyen self-assigned this Oct 1, 2024
@huong-li-nguyen huong-li-nguyen removed the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Oct 1, 2024
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review October 1, 2024 14:17
@huong-li-nguyen huong-li-nguyen changed the title [Tidy] Removal of font assignment to elements in vizro-bootstrap [Tidy] Remove font assignment to elements in vizro-bootstrap Oct 1, 2024
README.md Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) October 2, 2024 08:57
@huong-li-nguyen huong-li-nguyen merged commit 4bf865c into main Oct 2, 2024
34 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/add-updated-bootstrap-theme branch October 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants