-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Remove font assignment to elements in vizro-bootstrap #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huong-li-nguyen
changed the title
[Draft] Test out removal of font assignment to elements
[Tidy] Removal of font assignment to elements in vizro-bootstrap
Sep 30, 2024
huong-li-nguyen
commented
Oct 1, 2024
huong-li-nguyen
commented
Oct 1, 2024
huong-li-nguyen
requested review from
Joseph-Perkins,
antonymilne,
maxschulz-COL and
lingyielia
as code owners
October 1, 2024 14:17
pruthvip15
approved these changes
Oct 1, 2024
huong-li-nguyen
changed the title
[Tidy] Removal of font assignment to elements in vizro-bootstrap
[Tidy] Remove font assignment to elements in vizro-bootstrap
Oct 1, 2024
maxschulz-COL
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update HF links to show app in full height/width view
Removal of font-styling for elements
p, label, ul, li, blockquote and a
- based on this PR: https://github.com/McK-Private/vizro-bootstrap/pull/32These previously defined properties now lead to differences in the screenshots - decided to remove them and update all screenshots given that the QB design library doesn't assign any styling to elements either: https://github.com/mckinsey/vizro-qa/pull/122
Result: Elements will have no font-styling attached and will inherit anything their parent has.
Would like a review mostly from @pruthvip15 and then another codeowner so we can merge 👍
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":