Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Remove font assignment to elements in vizro-bootstrap #755

Merged
merged 14 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Our visual vocabulary dashboard helps you to select and create various types of
each chart type, and offers sample Python code to create these charts with [Plotly](https://plotly.com/python/) and
embed them into a Vizro dashboard.

<a href="https://huggingface.co/spaces/vizro/demo-visual-vocabulary/">
<a href="https://vizro-demo-visual-vocabulary.hf.space">
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
<img src="https://raw.githubusercontent.com/mckinsey/vizro/main/.github/images/visual_vocabulary.png" width="550">
</a>

Expand Down
2 changes: 1 addition & 1 deletion vizro-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Our visual vocabulary dashboard helps you to select and create various types of
each chart type, and offers sample Python code to create these charts with [Plotly](https://plotly.com/python/) and
embed them into a Vizro dashboard.

<a href="https://huggingface.co/spaces/vizro/demo-visual-vocabulary/">
<a href="https://vizro-demo-visual-vocabulary.hf.space">
<img src="https://raw.githubusercontent.com/mckinsey/vizro/main/.github/images/visual_vocabulary.png" width="550">
</a>

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨

- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Removed

- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Added

- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Changed

- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Deprecated

- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Fixed

- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Security

- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
4 changes: 0 additions & 4 deletions vizro-core/examples/visual-vocabulary/assets/css/custom.css
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ img[src*="#chart-icon"] {
margin: 0;
}

.intro-text p a {
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
font-size: inherit;
}

.intro-text ul:last-of-type {
margin-bottom: 0;
}
5 changes: 0 additions & 5 deletions vizro-core/src/vizro/static/css/bootstrap_overwrites.css
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ but do not want to take over to `vizro-bootstrap` as these settings might not be
margin-bottom: 0;
}

/* TO DO: Check if this should live in vizro-bootstrap */
.card p:last-of-type {
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
margin-bottom: 0;
}

.accordion-item .nav-link {
padding: 0.5rem 1rem;
}
Expand Down
2 changes: 1 addition & 1 deletion vizro-core/src/vizro/static/css/vizro-bootstrap.min.css

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading