Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo] Add diverging stacked bar chart to visual-vocabulary #795

Merged
merged 19 commits into from
Oct 17, 2024
Merged

[Demo] Add diverging stacked bar chart to visual-vocabulary #795

merged 19 commits into from
Oct 17, 2024

Conversation

hxe00570
Copy link
Contributor

@hxe00570 hxe00570 commented Oct 7, 2024 •
edited by huong-li-nguyen
Loading

Description

Issue -> #707

Screenshot

Screenshot 2024-10-16 at 16 13 58

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@hxe00570
[Docs] Replace preview image with gif (mckinsey#774)
bdf5a84 
## Description
Update to include diverging bar chart

## Screenshot

## Notice

- [X] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  - I submit this contribution under the [Apache 2.0 license](https://www.apache.org/licenses/LICENSE-2.0.txt) and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
  - I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
  - I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
  - I have not referenced individuals, products or companies in any commits, directly or indirectly.
  - I have not added data or restricted code in any commits, directly or indirectly.
@petar-qb petar-qb changed the title [Docs] Replace preview image with gif (#774) [GHC] Complete Diverging Bar to Vizro visual vocabulary (#774) Oct 8, 2024
@petar-qb petar-qb changed the title [GHC] Complete Diverging Bar to Vizro visual vocabulary (#774) [GHC] Complete Diverging Bar to Vizro visual vocabulary Oct 8, 2024
@huong-li-nguyen huong-li-nguyen changed the title [GHC] Complete Diverging Bar to Vizro visual vocabulary [Demo] Add diverging bar chart to visual-vocabulary Oct 8, 2024
@lingyielia lingyielia mentioned this pull request Oct 8, 2024
Merged
1 task
@huong-li-nguyen
Copy link
Contributor

huong-li-nguyen commented Oct 10, 2024 •
edited
Loading

@hxe00570 - could you provide me write access to your forked repository: https://github.com/hxe00570/vizro? :)

For this you need to go to your forked repository -> settings -> collaborators and teams --> add people

Then grant me write access :)

Screenshot 2024-10-10 at 11 51 13

@hxe00570
Copy link
Contributor Author

@huong-li-nguyen invite sent! I do not see where to grant permissions but I assume once you accept the invite I can do so.

@huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen invite sent! I do not see where to grant permissions but I assume once you accept the invite I can do so.

I just accepted :)

@huong-li-nguyen huong-li-nguyen changed the title [Demo] Add diverging bar chart to visual-vocabulary [Demo] Add diverging stacked bar chart to visual-vocabulary Oct 10, 2024
@huong-li-nguyen huong-li-nguyen linked an issue Oct 10, 2024 that may be closed by this pull request
Contribute Diverging stacked bar to Vizro visual vocabulary #706
Closed
@huong-li-nguyen huong-li-nguyen marked this pull request as draft October 16, 2024 08:45
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review October 16, 2024 14:23
@huong-li-nguyen
Copy link
Contributor

Thank you @hxe00570 for having a first stab at this! I've changed some of the logic of your original chart and refactored the chart to make reusing the chart function a bit simpler for people. You were already very close to the final solution! 🚀

I'll iterate on this after getting some reviews but I am sure we will merge this by the end of the week :)

petar-qb
petar-qb approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome example and its API added 🚀. This PR looks really good.

vizro-core/examples/visual-vocabulary/custom_charts.py Outdated Show resolved Hide resolved
vizro-core/examples/visual-vocabulary/pages/examples/diverging_stacked_bar.py Outdated Show resolved Hide resolved
antonymilne
antonymilne approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bit of a different way of doing this but I think we should merge this version as it is and then come back to it later 🙂

Thank you for all your hard work on this @hxe00570 and @huong-li-nguyen 🙏 I know it wasn't an easy chart to do!

@huong-li-nguyen huong-li-nguyen merged commit 916cc7d into mckinsey:main Oct 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petar-qb petar-qb petar-qb approved these changes

@huong-li-nguyen huong-li-nguyen huong-li-nguyen left review comments

@antonymilne antonymilne antonymilne approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@maxschulz-COL maxschulz-COL Awaiting requested review from maxschulz-COL maxschulz-COL is a code owner

@lingyielia lingyielia Awaiting requested review from lingyielia lingyielia is a code owner

@nadijagraca nadijagraca Awaiting requested review from nadijagraca

Assignees

@huong-li-nguyen huong-li-nguyen

@hxe00570 hxe00570

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contribute Diverging stacked bar to Vizro visual vocabulary
4 participants
@hxe00570 @huong-li-nguyen @antonymilne @petar-qb