-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Replace dmc.Tabs
with dbc.Tabs
#895
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…izro into tidy/remove-variables
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, but looks good to my understanding.
Amazing work 👍
for more information, see https://pre-commit.ci
…izro into tidy/remove-variables
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open it in an incognito browser? I think your browser might have cached an old CSS file? In your screenshot there is no styling applied to the tabs. It should look like this: |
I get this in incognito - this is the link to PyCafe: |
Can you try to run it locally? PyCafe doesn't seem to pull the latest bootstrap file which is in that branch. |
for more information, see https://pre-commit.ci
Description
We initially used
dmc.Tabs
due to an issue withdbc.Tabs
at the time of development. Specifically, Plotly charts withindbc.Tabs
did not resize correctly, requiring either a fixed height for the charts or the use of the callback method for the tabs, which we wanted to avoid. For more context on the previous issue, see:I took another look at
dbc.Tabs
, and it seems to be working great now 🥳.It did take a bit of work to get everything running smoothly because the HTML structure for the Bootstrap component is very different. Plus,
dbc
adds an extradiv
for some reason that we can't assign aclassName
to. This led to a couple of CSS issues, which are now sorted out. I left a comment about it, but we shouldn't need to change it anymore.Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":