Mark Safari Tech Preview as partially supporting source option for popover API #25964
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pover API Also mark Chrome support as partial due to missing focus behavior
github-actions
bot
added
data:api
caugner
reviewed
Feb 19, 2025
| "version_added": "133" | ||
| "version_added": "133", | ||
| "partial_implementation": true, | ||
| "notes": "This doesn't apply the focus ordering change. See [bug 383343310](https://crbug.com/383343310)." |
There was a problem hiding this comment.
Can you elaborate what "focus ordering change" refers to here, and why it is specific to the source option?
PS: While we're here, maybe we could add this spec_url: https://html.spec.whatwg.org/multipage/dom.html#dom-showpopoveroptions-source
There was a problem hiding this comment.
If I understand this correctly, we could rephrase it for users as follows:
When using this option, the focus order doesn't change, so the popover does not become the next focus element.
You might be able to help out making this more idiomatic.
There was a problem hiding this comment.
Suggested change
| "notes": "This doesn't apply the focus ordering change. See [bug 383343310](https://crbug.com/383343310)." | |
| "notes": "When using this option, the focus order doesn't change, so the popover does not become the next focus element. See [bug 383343310](https://crbug.com/383343310)." |
There was a problem hiding this comment.
That sounds good and yes I'll add the spec URL too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mark Chrome support as partial due to missing focus behavior
Summary
Mark Safari Tech Preview as partially supporting source option for popover API
Also mark Chrome support as partial due to missing focus behavior
Test results and supporting details
Manually tested STP support by running https://wpt.live/html/semantics/popovers/imperative-invokers.html
Related issues