Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Safari Tech Preview as partially supporting source option for popover API #25964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Mark Safari Tech Preview as partially supporting source option for popover API #25964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions api/HTMLElement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,7 +2458,9 @@
],
"support": {
"chrome": {
"version_added": "133"
"version_added": "133",
"partial_implementation": true,
"notes": "This doesn't apply the focus ordering change. See [bug 383343310](https://crbug.com/383343310)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate what "focus ordering change" refers to here, and why it is specific to the source option?

PS: While we're here, maybe we could add this spec_url: https://html.spec.whatwg.org/multipage/dom.html#dom-showpopoveroptions-source

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, we could rephrase it for users as follows:

When using this option, the focus order doesn't change, so the popover does not become the next focus element.

You might be able to help out making this more idiomatic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"notes": "This doesn't apply the focus ordering change. See [bug 383343310](https://crbug.com/383343310)."
"notes": "When using this option, the focus order doesn't change, so the popover does not become the next focus element. See [bug 383343310](https://crbug.com/383343310)."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good and yes I'll add the spec URL too

},
"chrome_android": "mirror",
"edge": "mirror",
Expand All @@ -2473,7 +2475,9 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
"version_added": "preview",
"partial_implementation": true,
"notes": "This doesn't apply the focus ordering change. See [bug 286575](https://webkit.org/b/286575)."
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
Expand Down Expand Up @@ -2957,7 +2961,9 @@
],
"support": {
"chrome": {
"version_added": "133"
"version_added": "133",
"partial_implementation": true,
"notes": "This doesn't apply the focus ordering change. See [bug 383343310](https://crbug.com/383343310)."
},
"chrome_android": "mirror",
"edge": "mirror",
Expand All @@ -2972,7 +2978,9 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
"version_added": "preview",
"partial_implementation": true,
"notes": "This doesn't apply the focus ordering change. See [bug 286575](https://webkit.org/b/286575)."
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
Expand Down