-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Technical review for Shared Storage API docs #28051
Changes from 1 commit
09f74e0
7a1984e
d4dced4
1928e17
ce9e2d1
c2fff8a
702386f
b3ee6b7
a994416
6a17946
f2af72d
4dc61f8
3ac68d5
8a3b64f
11e3ee4
82fc773
d6eab15
61420ea
62162fe
1fb0ac3
c983300
1de28cc
603ae92
c95f524
2356250
502c2f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ None (`undefined`). | |
- An operation has already been registered with the specified name. | ||
- The `operationCtor` is not a valid constructor. | ||
- The class does not contain a valid `run()` method. | ||
- The calling site does not have the Shared Storage API included in a successful [privacy sandbox enrollment process](/en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We actually don't check for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, removed. |
||
- The worklet module has not been added with {{domxref("Worklet.addModule", "SharedStorageWorklet.addModule()")}}. | ||
|
||
## Examples | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to put another note here like to match the notes in the three other setter/deleter methods, e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pythagoraskitty Yes, good idea. I have done so.
Can you let me know if there are any other changes you think this PR needs? If not, give me an "LGTM", and I will consider it signed off on technical review, after which I can get someone on the MDN content team to give it a final editorial review.
Thanks!