DO NOT MERGE: Technical review for Shared Storage API docs #28051

chrisdavidmills · 2023-07-19T14:14:13Z

Note: This technical review is now completed and approved. For the follow-on editorial review, see #30427

Description

The Shared Storage API is an integral part of Google's privacy sandbox technologies. Many parts of this set are being made available by default in Chrome 115 (depending on a gradual ramp-up to 100% of userbase over the 115 release period).

This PR adds content for Shared Storage. See my research document for information on exactly what features are being added.

Motivation

Additional details

Related issues and pull requests

github-actions · 2023-07-19T14:16:17Z

Preview URLs (30 pages)

Flaws (81)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WindowSharedStorage
Title: WindowSharedStorage
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WindowSharedStorage/selectURL
Title: WindowSharedStorage: selectURL() method
Flaw count: 8

macros:
- /en-US/docs/Web/API/Fence/reportEvent does not exist
- /en-US/docs/Web/API/Fence/setReportEventDataForAutomaticBeacons does not exist
- /en-US/docs/Web/API/FencedFrameConfig does not exist
- /en-US/docs/Web/HTML/Element/fencedframe does not exist
- /en-US/docs/Web/API/FencedFrameConfig does not exist
broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WindowSharedStorage/worklet
Title: WindowSharedStorage: worklet property
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WindowSharedStorage/run
Title: WindowSharedStorage: run() method
Flaw count: 3

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageWorkletGlobalScope
Title: SharedStorageWorkletGlobalScope
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageWorkletGlobalScope/register
Title: SharedStorageWorkletGlobalScope: register() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageWorkletGlobalScope/sharedStorage
Title: SharedStorageWorkletGlobalScope: sharedStorage property
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageSelectURLOperation
Title: SharedStorageSelectURLOperation
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageSelectURLOperation/run
Title: SharedStorageSelectURLOperation: run() method
Flaw count: 3

macros:
- /en-US/docs/Web/API/Fence/reportEvent does not exist
- /en-US/docs/Web/API/Fence/setReportEventDataForAutomaticBeacons does not exist
broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage
Title: WorkletSharedStorage
Flaw count: 3

macros:
- /en-US/docs/Web/API/FencedFrameConfig/setSharedStorageContext does not exist
- /en-US/docs/Web/API/WorkletSharedStorage/values does not exist
broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage/entries
Title: WorkletSharedStorage: entries() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage/keys
Title: WorkletSharedStorage: keys() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage/context
Title: WorkletSharedStorage: context property
Flaw count: 4

macros:
- /en-US/docs/Web/API/FencedFrameConfig/setSharedStorageContext does not exist
- /en-US/docs/Web/API/FencedFrameConfig/setSharedStorageContext does not exist
- /en-US/docs/Web/API/FencedFrameConfig does not exist
broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage/get
Title: WorkletSharedStorage: get() method
Flaw count: 3

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage/length
Title: WorkletSharedStorage: length() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/WorkletSharedStorage/remainingBudget
Title: WorkletSharedStorage: remainingBudget() method
Flaw count: 4

macros:
- /en-US/docs/Web/HTML/Element/fencedframe does not exist
broken_links:
- Can't resolve /en-US/docs/Web/API/Fenced_Frame_API
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/Shared_Storage_API
Title: Shared Storage API
Flaw count: 6

macros:
- /en-US/docs/Web/API/FencedFrameConfig does not exist
- /en-US/docs/Web/API/HTMLFencedFrameElement/config does not exist
- /en-US/docs/Web/HTML/Element/fencedframe does not exist
broken_links:
- Can't resolve /en-US/docs/Web/API/Fenced_Frame_API
- Can't resolve /en-US/docs/Web/API/Fenced_Frame_API
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment

URL: /en-US/docs/Web/API/Worklet
Title: Worklet
Flaw count: 2

macros:
- /en-US/docs/Web/API/AnimationWorklet does not exist
- /en-US/docs/Web/API/LayoutWorklet does not exist

URL: /en-US/docs/Web/API/SharedStorageRunOperation
Title: SharedStorageRunOperation
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageRunOperation/run
Title: SharedStorageRunOperation: run() method
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/Window
Title: Window
Flaw count: 10

macros:
- /en-US/docs/Web/API/Window/setResizable does not exist
- /en-US/docs/Web/API/Window/animationcancel_event redirects to /en-US/docs/Web/API/Element/animationcancel_event
- /en-US/docs/Web/API/Window/animationend_event redirects to /en-US/docs/Web/API/Element/animationend_event
- /en-US/docs/Web/API/Window/animationiteration_event redirects to /en-US/docs/Web/API/Element/animationiteration_event
- /en-US/docs/Web/API/Window/animationstart_event redirects to /en-US/docs/Web/API/Element/animationstart_event
- and 4 more flaws omitted
broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/Window/sharedStorage
Title: Window: sharedStorage property
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageOperation
Title: SharedStorageOperation
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorage
Title: SharedStorage
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorage/delete
Title: SharedStorage: delete() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorage/set
Title: SharedStorage: set() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorage/append
Title: SharedStorage: append() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorage/clear
Title: SharedStorage: clear() method
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

URL: /en-US/docs/Web/API/SharedStorageWorklet
Title: SharedStorageWorklet
Flaw count: 3

broken_links:
- Can't resolve /en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment
- Can't resolve /en-US/docs/Web/API/Shared_storage_API
- Can't resolve /en-US/docs/Web/API/Shared_storage_API

External URLs (18)

URL: /en-US/docs/Web/API/WindowSharedStorage/run
Title: WindowSharedStorage: run() method

https://developer.chrome.com/docs/privacy-sandbox/shared-storage/unique-reach/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/WorkletSharedStorage
Title: WorkletSharedStorage

https://developer.chrome.com/docs/privacy-sandbox/fledge/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/private-aggregation/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/WorkletSharedStorage/get
Title: WorkletSharedStorage: get() method

https://developer.chrome.com/docs/privacy-sandbox/shared-storage/k-freq-reach/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/Shared_Storage_API
Title: Shared Storage API

https://developer.chrome.com/docs/privacy-sandbox/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/private-aggregation/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/ab-testing/ (2 times) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/creative-rotation/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/k-freq-reach/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/known-customer/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/unique-reach/ (1 time) (Note! This may be a new URL 👀)
https://developer.chrome.com/docs/privacy-sandbox/shared-storage/user-demographics/ (1 time) (Note! This may be a new URL 👀)
https://shared-storage-demo.web.app/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/Worklet
Title: Worklet

https://wicg.github.io/shared-storage/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/SharedStorageRunOperation
Title: SharedStorageRunOperation

https://developer.chrome.com/docs/privacy-sandbox/shared-storage/unique-reach/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/SharedStorageOperation
Title: SharedStorageOperation

https://developer.chrome.com/docs/privacy-sandbox/private-aggregation/ (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-11-21 09:00:41)

files/en-us/web/api/shared_storage_api/index.md

files/en-us/web/api/sharedstorage/index.md

files/en-us/web/api/sharedstorage/set/index.md

Co-authored-by: sideshowbarker <[email protected]>

…nt into shared-storage-api

files/en-us/web/api/sharedstorage/append/index.md

files/en-us/web/api/sharedstorageoperation/index.md

files/en-us/web/api/sharedstorage/append/index.md

files/en-us/web/api/sharedstorage/clear/index.md

files/en-us/web/api/sharedstorage/delete/index.md

files/en-us/web/api/windowsharedstorage/selecturl/index.md

files/en-us/web/api/workletsharedstorage/values/index.md

files/en-us/web/api/workletsharedstorage/context/index.md

pythagoraskitty · 2023-07-31T22:42:03Z

files/en-us/web/api/workletsharedstorage/get/index.md

+  - : Thrown if:
+    - The worklet module has not yet been added with {{domxref("Worklet.addModule", "addModule()")}}.
+    - `key` exceeds the browser-defined maximum length.
+    - A key/value with the specified `key` is not found in the shared storage.


If the key is not found, the operation doesn't throw/reject. Instead, it resolves to undefined.

OK, I've removed that sentence, and updated the return value description to:

A {{jsxref("Promise")}} that fulfills with a string equal to the value of the retrieved key/value pair, or undefined if the specified key is not found in the shared storage.

Does this one throw if shared storage is disabled, like set(), append(), etc.?

(All of the methods do.)

files/en-us/web/api/workletsharedstorage/remainingbudget/index.md

pythagoraskitty · 2023-09-27T22:07:40Z

files/en-us/web/api/workletsharedstorage/remainingbudget/index.md

+{{APIRef("Shared Storage API")}}{{SeeCompatTable}}
+
+The **`remainingBudget()`** method of the
+{{domxref("WorkletSharedStorage")}} interface returns the remaining navigation budget for the current origin.


See comment.

pythagoraskitty · 2023-09-27T22:08:26Z

files/en-us/web/api/workletsharedstorage/remainingbudget/index.md

+The **`remainingBudget()`** method of the
+{{domxref("WorkletSharedStorage")}} interface returns the remaining navigation budget for the current origin.
+
+The navigation budget is the number of bits of entropy permitted inside a {{htmlelement("fencedframe")}} as a result of {{domxref("WindowSharedStorage.selectURL()")}} calls, per origin, per 24-hour time period. This is not the same as the number of navigations; rather it is based on the number of potential navigations in each call. Each time a `selectURL()` navigation occurs, an amount equal to logarithm base 2 of the number of URL choices is deducted from the corresponding origin's budget.


Ditto. Soon origin --> site.

pythagoraskitty · 2023-09-27T22:11:48Z

Apologies, I had forgotten about this. Took another look and left some more comments. Looks good apart from these.

chrisdavidmills · 2023-09-28T12:30:26Z

Apologies, I had forgotten about this. Took another look and left some more comments. Looks good apart from these.

@pythagoraskitty thanks so much for having another look; I really appreciate your time. I've made fixes for all the 2nd round review comments; there are just a couple more queries for you/bits you might want to check.

github-actions · 2023-10-16T10:16:15Z

This pull request has merge conflicts that must be resolved before it can be merged.

pythagoraskitty · 2023-10-19T17:47:55Z

files/en-us/web/api/sharedstorage/delete/index.md

+  - The `Promise` rejects with a {{jsxref("TypeError")}} if `key` exceeds the browser-defined maximum length.
+
+> **Note:** If the key/value pair doesn't exist in the shared storage, no error is thrown — the operation still fulfills with `undefined`.
+


Did you want to put another note here like to match the notes in the three other setter/deleter methods, e.g.

> **Note:** In the case of {{domxref("WindowSharedStorage")}}, if the `delete()` operation doesn't successfully write to the database for a reason other than shared storage not being available, no error is thrown — the operation still fulfills with `undefined`.

@pythagoraskitty Yes, good idea. I have done so.

Can you let me know if there are any other changes you think this PR needs? If not, give me an "LGTM", and I will consider it signed off on technical review, after which I can get someone on the MDN content team to give it a final editorial review.

Thanks!

chrisdavidmills · 2023-11-17T21:36:55Z

@pythagoraskitty Hi there! I just added enrollment information to the PR, as that was missing before. Have I presented an accurate picture of how the API fails to work if the calling site is not enrolled as appropriate?

(The actual enrollment page is not part of the PR; I added it to the Topics API, and it should be merged by the time this PR is merged; see https://pr30107.content.dev.mdn.mozit.cloud/en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment for a preview)

pythagoraskitty · 2023-11-17T23:26:17Z

files/en-us/web/api/shared_storage_api/index.md

+- The {{domxref("WorkletSharedStorage.remainingBudget()")}} method
+  - : The promise returned by `remainingBudget()` rejects with a `TypeError` {{domxref("DOMException")}}.
+- The {{domxref("WindowSharedStorage.run()")}} and {{domxref("WindowSharedStorage.selectURL()")}} methods
+  - : Promises returned by run and URL selection operations will reject with a `TypeError` {{domxref("DOMException")}}.


Actually, all of the shared storage methods required enrollment, not just the ones listed here, but it's a little buried in the spec.

If you look at the references to https://wicg.github.io/shared-storage/#determine-whether-shared-storage-is-allowed, you will see among them https://wicg.github.io/shared-storage/#ref-for-determine-whether-shared-storage-is-allowed%E2%91%A0 in https://wicg.github.io/shared-storage/#obtain-a-shared-storage-shelf.

The latter is referenced at https://wicg.github.io/shared-storage/#ref-for-obtain-a-shared-storage-shelf in https://wicg.github.io/shared-storage/#obtain-a-shared-storage-bottle-map, which in turn is referenced in all of the methods except those you've already listed here.

(Since the methods you've listed here don't need a bottle map, they reference the https://wicg.github.io/shared-storage/#determine-whether-shared-storage-is-allowed directly.)

So perhaps instead of listed the methods individually here, say that all shared storage sub-features will fail? Or else list them all rejecting with a TypeError if you prefer?

Also note that https://wicg.github.io/shared-storage/#check-if-addmodule-is-allowed-and-update-status references https://wicg.github.io/shared-storage/#determine-whether-shared-storage-is-allowed as well, so addModule() also requires enrollment.

Ah, thanks for helping me understand this. I have updated the comment on the API landing page and added exception information to all API methods, as advised.

Let me know if this PR needs anything else, or give me an "LGTM" if it looks OK. Thanks!

pythagoraskitty · 2023-11-17T23:27:48Z

files/en-us/web/api/windowsharedstorage/run/index.md

@@ -43,6 +43,7 @@ A {{jsxref("Promise")}} that fulfills with `undefined`.
  - : Thrown if:
    - The worklet module has not yet been added with {{domxref("Worklet.addModule", "addModule()")}}.
    - Shared storage is disabled (for example via a browser setting).
+    - The calling site does not have the Shared Storage API included in a successful [privacy sandbox enrollment process](/en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment).


Perhaps add this same item to all methods?

pythagoraskitty · 2023-11-17T23:30:43Z

Will look good if you address my comments above. Thanks for adding this!

pythagoraskitty · 2023-11-20T18:28:44Z

files/en-us/web/api/sharedstorageworkletglobalscope/register/index.md

@@ -37,6 +37,7 @@ None (`undefined`).
    - An operation has already been registered with the specified name.
    - The `operationCtor` is not a valid constructor.
    - The class does not contain a valid `run()` method.
+    - The calling site does not have the Shared Storage API included in a successful [privacy sandbox enrollment process](/en-US/docs/Web/Privacy/Privacy_sandbox/Enrollment).


We actually don't check for register(), which won't get to run in any case if addModule() is rejected due to lack of enrollment. So you can leave this one out.

OK, removed.

pythagoraskitty

LGTM mod the comment I made for register().

chrisdavidmills · 2023-11-21T08:58:24Z

LGTM mod the comment I made for register().

Great, thank you @pythagoraskitty! The next stage is to close this technical review PR, and open up a new PR based on the same branch to contain the editorial review.

Add first draft of Shared Storage API landing page

09f74e0

chrisdavidmills requested review from a team as code owners July 19, 2023 14:14

chrisdavidmills requested review from sideshowbarker and bsmth and removed request for a team July 19, 2023 14:14

github-actions bot added the Content:WebAPI Web API docs label Jul 19, 2023

Add sharedstorage class

7a1984e

chrisdavidmills marked this pull request as draft July 19, 2023 18:01

sideshowbarker approved these changes Jul 20, 2023

View reviewed changes

chrisdavidmills changed the title ~~Add first draft of Shared Storage API landing page~~ Shared Storage API Jul 20, 2023

chrisdavidmills added 2 commits July 23, 2023 21:34

Lots more progress on documenting the interfaces

d4dced4

final bits of content

1928e17

chrisdavidmills marked this pull request as ready for review July 24, 2023 08:14

chrisdavidmills and others added 10 commits July 24, 2023 09:15

Merge branch 'main' into shared-storage-api

ce9e2d1

Update files/en-us/web/api/shared_storage_api/index.md

c2fff8a

Co-authored-by: sideshowbarker <[email protected]>

Update files/en-us/web/api/shared_storage_api/index.md

702386f

Co-authored-by: sideshowbarker <[email protected]>

Update files/en-us/web/api/sharedstorage/index.md

b3ee6b7

Co-authored-by: sideshowbarker <[email protected]>

Update files/en-us/web/api/sharedstorage/set/index.md

a994416

Co-authored-by: sideshowbarker <[email protected]>

small tweak

6a17946

Merge branch 'main' into shared-storage-api

f2af72d

Change Select URL gate name to Content Selection

4dc61f8

Merge branch 'shared-storage-api' of github.com:chrisdavidmills/conte…

3ac68d5

…nt into shared-storage-api

Add multiple operations example

8a3b64f

xyaoinum reviewed Jul 26, 2023

View reviewed changes

files/en-us/web/api/sharedstorage/append/index.md Outdated Show resolved Hide resolved

xyaoinum reviewed Jul 26, 2023

View reviewed changes

files/en-us/web/api/sharedstorageoperation/index.md Outdated Show resolved Hide resolved

pythagoraskitty reviewed Jul 31, 2023

View reviewed changes

Fixes according to pythagoraskitty comments

11e3ee4

pythagoraskitty reviewed Sep 27, 2023

View reviewed changes

chrisdavidmills added 2 commits September 28, 2023 12:18

Merge branch 'main' into shared-storage-api

61420ea

Fixes make for pythagoraskitty 2nd tech review

62162fe

github-actions bot added the merge conflicts 🚧 [PR only] label Oct 16, 2023

Merge branch 'main' into shared-storage-api

1fb0ac3

github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 16, 2023

pythagoraskitty reviewed Oct 19, 2023

View reviewed changes

Add note and fix error on SharedStorage.delete() page

c983300

skyclouds2001 mentioned this pull request Nov 3, 2023

Add content for Shared Storage API #30004

Closed

chrisdavidmills added 2 commits November 17, 2023 20:51

Merge branch 'main' into shared-storage-api

1de28cc

Add enrollment information

603ae92

pythagoraskitty reviewed Nov 17, 2023

View reviewed changes

Update enrollment information in light of pythagoraskitty review

c95f524

chrisdavidmills requested a review from pythagoraskitty November 20, 2023 15:47

pythagoraskitty reviewed Nov 20, 2023

View reviewed changes

Remove enrollment exception criteria from register() as per review

2356250

Merge branch 'main' into shared-storage-api

502c2f3

chrisdavidmills changed the title ~~Shared Storage API~~ DO NOT MERGE: Technical review for Shared Storage API docs Nov 21, 2023

chrisdavidmills closed this Nov 21, 2023

chrisdavidmills mentioned this pull request Nov 21, 2023

feat: Editorial review for Shared Storage API docs #30427

Merged

bsmth removed their request for review December 1, 2023 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE: Technical review for Shared Storage API docs #28051

DO NOT MERGE: Technical review for Shared Storage API docs #28051

chrisdavidmills commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

pythagoraskitty Jul 31, 2023

chrisdavidmills Aug 3, 2023

chrisdavidmills Aug 3, 2023

pythagoraskitty Sep 28, 2023

pythagoraskitty Sep 28, 2023

pythagoraskitty Sep 27, 2023

pythagoraskitty Sep 27, 2023

pythagoraskitty commented Sep 27, 2023

chrisdavidmills commented Sep 28, 2023

github-actions bot commented Oct 16, 2023

pythagoraskitty Oct 19, 2023

chrisdavidmills Oct 27, 2023

chrisdavidmills commented Nov 17, 2023

pythagoraskitty Nov 17, 2023

pythagoraskitty Nov 17, 2023

chrisdavidmills Nov 20, 2023

pythagoraskitty Nov 17, 2023

pythagoraskitty commented Nov 17, 2023

pythagoraskitty Nov 20, 2023

chrisdavidmills Nov 21, 2023

pythagoraskitty left a comment

chrisdavidmills commented Nov 21, 2023

		- The `Promise` rejects with a {{jsxref("TypeError")}} if `key` exceeds the browser-defined maximum length.

		> Note: If the key/value pair doesn't exist in the shared storage, no error is thrown — the operation still fulfills with `undefined`.

DO NOT MERGE: Technical review for Shared Storage API docs #28051

DO NOT MERGE: Technical review for Shared Storage API docs #28051

Conversation

chrisdavidmills commented Jul 19, 2023 • edited Loading

Description

Motivation

Additional details

Related issues and pull requests

github-actions bot commented Jul 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pythagoraskitty commented Sep 27, 2023

chrisdavidmills commented Sep 28, 2023

github-actions bot commented Oct 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills commented Nov 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pythagoraskitty commented Nov 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pythagoraskitty left a comment

Choose a reason for hiding this comment

chrisdavidmills commented Nov 21, 2023

chrisdavidmills commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading