FF116 Intl.PluralRules - NumFormat v3 #28097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Jul 21, 2023
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/pluralrules/index.md
Show resolved
Hide resolved
|
Worth getting some feedback now. |
hamishwillee
commented
Jul 24, 2023
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
hamishwillee
commented
Jul 24, 2023
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/selectrange/index.md
Outdated
Show resolved
Hide resolved
10 tasks
Josh-Cena
reviewed
Jul 25, 2023
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/select/index.md
Outdated
Show resolved
Hide resolved
…lrules/index.md Co-authored-by: Joshua Chen <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
…lrules/index.md Co-authored-by: Joshua Chen <[email protected]>
hamishwillee
commented
Jul 28, 2023
Comment on lines
+25
to
+32
| Creating appropriate sentences for each form depends on the language, and even in English may not be as simple as just adding "s" to a noun to make the plural form. | ||
| Using the example above, we see that the form may affect: | ||
|
|
||
| - **Nouns**: 1 dogs/2 dogs (but not "fish" or "sheep", which have the same singular and plural form). | ||
| - **Verbs**: 1 dog _is_ happy, 2 dogs _are_ happy | ||
| - **Pronouns** (and other referents): Do you want to play with _it_ / _them_. | ||
|
|
||
| Other languages have more forms, and choosing appropriate sentences can be even more complex. |
There was a problem hiding this comment.
With respect to #28097 (comment) (" This is very interesting, because when people think of "plural" they usually think of changing the noun ...)
Yes. I've stolen the form of your comment and inserted it in the text here. I had thought about this, but found it hard to decide what should be included, particularly when I don't "grok" the full discussion in https://cldr.unicode.org/index/cldr-spec/plural-rules - especially when it gets down to the Welsh.
Its a good suggestion. Hope this meets with your approval. Other suggestions merged.
Josh-Cena
approved these changes
Jul 28, 2023
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/select/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/select/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/selectrange/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/pluralrules/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/pluralrules/index.md
Outdated
Show resolved
Hide resolved
|
Thanks for the review Josh! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing constructor options to the
Intl.PluralRulesconstructor andPluralRules/resolvedOptions()It also adds some information about what the PluralRules do - i.e. the previous version was too high level.