Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url added: loadstart url added to event #28242

Merged
merged 3 commits into from
Jul 29, 2023
Merged

url added: loadstart url added to event #28242

merged 3 commits into from
Jul 29, 2023

Conversation

rohini-ranjanR
Copy link
Contributor

Description

Adding loadstart URL in event section https://developer.mozilla.org/en-US/docs/Web/HTML/Element/audio#events

Motivation

Additional details

Related issues and pull requests

Fixes #27820

@rohini-ranjanR rohini-ranjanR requested a review from a team as a code owner July 28, 2023 13:45
@rohini-ranjanR rohini-ranjanR requested review from chrisdavidmills and removed request for a team July 28, 2023 13:45
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Jul 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-07-29 15:18:14)

@rohini-ranjanR rohini-ranjanR mentioned this pull request Jul 28, 2023
Merged
wbamberg
wbamberg reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, @rohini-ranjanR ! I had a copy-edit suggestion (I took the words mostly from https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement#loadstart).

The issue (#27820) also mentions updating the <video> page: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video#events. Do you want to take care of that in this PR as well?

files/en-us/web/html/element/audio/index.md Outdated Show resolved Hide resolved
@rohini-ranjanR
Copy link
Contributor Author

Thank you for your PR, @rohini-ranjanR ! I had a copy-edit suggestion (I took the words mostly from https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement#loadstart).

The issue (#27820) also mentions updating the <video> page: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video#events. Do you want to take care of that in this PR as well?

Sure

wbamberg
wbamberg approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @rohini-ranjanR !

@wbamberg wbamberg merged commit 7b88296 into mdn:main Jul 29, 2023
7 checks passed
@rohini-ranjanR rohini-ranjanR deleted the issue_solving branch July 31, 2023 01:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"loadstart" event not linked to from <audio>/<video> pages
2 participants
@rohini-ranjanR @wbamberg