docs(hgroup): adds related note from a different page #30856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading through this page: https://developer.mozilla.org/en-US/docs/Web/HTML/Content_categories when I came across this note: Note: The <hgroup> element is not recommended as it does not work properly with assistive technologies. It was removed from the W3C HTML specification prior to HTML 5 being finalized, but is still part of the WHATWG specification and is at least partially supported by most browsers. I believe it's important to include this note in <hgroup>'s page because as it stands right now it might mislead developers into using it, thinking that it has no drawbacks. Someone might use <hgroup> instead of a <div> due to preference, so they can use it in a css selector or to create a reusable pre-styled container and unknowingly make their website less acessible.
|
Preview URLs (comment last updated: 2023-12-09 03:32:05) |
Following `<optgroup>`'s example, I think it would be better for such an important note to be at the top
estelle
reviewed
Dec 9, 2023
estelle
reviewed
Dec 9, 2023
|
Thanks a lot. Glad to be here! |
dipikabh
pushed a commit
to dipikabh/content
that referenced
this pull request
Jan 17, 2024
* docs(hgroup): adds related note from a different page I was reading through this page: https://developer.mozilla.org/en-US/docs/Web/HTML/Content_categories when I came across this note: Note: The <hgroup> element is not recommended as it does not work properly with assistive technologies. It was removed from the W3C HTML specification prior to HTML 5 being finalized, but is still part of the WHATWG specification and is at least partially supported by most browsers. I believe it's important to include this note in <hgroup>'s page because as it stands right now it might mislead developers into using it, thinking that it has no drawbacks. Someone might use <hgroup> instead of a <div> due to preference, so they can use it in a css selector or to create a reusable pre-styled container and unknowingly make their website less acessible. * refactor(hgroup): moves note to the top Following `<optgroup>`'s example, I think it would be better for such an important note to be at the top * refactor(hgroup): removes self-referencing anchor tag * Update files/en-us/web/html/element/hgroup/index.md --------- Co-authored-by: Estelle Weyl <[email protected]>
thibaudcolas
added a commit
to thibaudcolas/mdn-content
that referenced
this pull request
Feb 11, 2024
)" This reverts commit fbb5b30.
thibaudcolas
added a commit
to thibaudcolas/mdn-content
that referenced
this pull request
Feb 11, 2024
)" This reverts commit fbb5b30.
estelle
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds note about
<hgroup>previously only found on the Content categories page to<hgroup>'s pageMotivation
I believe it's important to include this note in
<hgroup>'s page because as it stands right now it might mislead developers into using it, thinking that it has no drawbacks.Someone might use
<hgroup>instead of a<div>due to preference, so they can use it in a css selector or to create a reusable pre-styled container and unknowingly make their website less acessible.