Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(hgroup): adds related note from a different page #30856

Merged
merged 4 commits into from
Dec 9, 2023

Commits on Dec 7, 2023

  1. docs(hgroup): adds related note from a different page

    I was reading through this page:
    https://developer.mozilla.org/en-US/docs/Web/HTML/Content_categories
    
    when I came across this note:
    
    Note: The <hgroup> element is not recommended as it does not work properly with assistive technologies. It was removed from the W3C HTML specification prior to HTML 5 being finalized, but is still part of the WHATWG specification and is at least partially supported by most browsers.
    
    I believe it's important to include this note in <hgroup>'s page because as it stands right now it might mislead developers into using it, thinking that it has no drawbacks.
    
    Someone might use <hgroup> instead of a <div> due to preference, so they can use it in a css selector or to create a reusable pre-styled container and unknowingly make their website less acessible.
    kenji-webdev authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8b5f9a4 View commit details
    Browse the repository at this point in the history
  2. refactor(hgroup): moves note to the top

    Following `<optgroup>`'s example, I think it would be better for such an important note to be at the top
    kenji-webdev authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    41b630b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc02a72 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Configuration menu
    Copy the full SHA
    678fbab View commit details
    Browse the repository at this point in the history