-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Technical review: Document cross-document view transitions #32723
Technical review: Document cross-document view transitions #32723
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, but here’s a review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More code comments. For the one in pageswap
I await e.viewTransition.finished
, for the one in pagereveal
it’s e.viewTransition.ready
.
Co-authored-by: Bramus <[email protected]>
Co-authored-by: Bramus <[email protected]>
Co-authored-by: Bramus <[email protected]>
Co-authored-by: Bramus <[email protected]>
Co-authored-by: Bramus <[email protected]>
Co-authored-by: Bramus <[email protected]>
Thanks again @bramus. I made a couple more updates in light of your further comments. Let me know if you spot anything else. If not, then we can probably move this forward to editorial review stage. One thing (which is not a blocker) — I updated the comment about BFCache in the code to:
Can you explain what this comment means? Because readers will wonder. I'd like to add an explanation. I think I know what this is getting at, but I want to make sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
On page1, in |
OK, closing this PR. Next stage is to create a new PR based on the same branch to contain the editorial review. |
Note: This technical review is now completed and approved. For the follow-on editorial review, see #34118
Description
Chrome 123/124 includes features required for developers to create cross-document View Transitions. This includes:
PageRevealEvent
interfacepagereveal
eventPageSwapEvent
interfacepageswap
eventNavigationActivation
interface@view-transition
at rule<link rel="expect">
This PR adds content for all of these. In addition, it:
Related ChromeStatus entries:
Motivation
Additional details
Related issues and pull requests