Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Technical review: Document cross-document view transitions #32723
Technical review: Document cross-document view transitions #32723
Changes from 53 commits
c7dcd4e
218ab88
b82a640
000fa78
429ef2f
d891779
30accf7
30eb72d
a03d960
ce1710d
8b88c2a
7c50ef8
3a33825
dd176af
175a58b
a55a815
4224491
8640c51
8f3dfaa
290489c
0973ce2
79b7ca3
3a50822
2afc294
4f19f17
b9a7530
9e1d074
7fe0eaf
0b142e5
c894f7b
a768586
d788f87
03dccd3
6ad60a1
45fa318
be95206
bb868a0
4191156
6faaebb
d6d62ed
c4ef9cc
781ad75
220f138
fdd0cd2
d557f5c
ecdc3d3
c7fa835
c203f38
3022d22
f757a64
1d2e5d3
7f84898
c97f061
632d453
64b2e7e
0aef236
34fadad
afcc431
4913b12
cc29537
e3ead76
6fff811
aec4da8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably say a word about it regardless of view-transitions. It's equivalent to the first
requestAnimationFrame()
after a cross-document navigation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand on this? I'm not sure I 100% understand it. Are you saying that the event itself is equivalent to the first
requestAnimationFrame()
after a cross-document navigation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly, it's roughly equivalent to something like this in the head:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think readers will find this confusing, and ask questions about how
requestAnimationFrame()
is involved in the view transition. Is a rAF() call use internally to run the animation — is that what you are saying? And how is that useful to the developer? Can they so something beneficial with that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common use case for this outside of view-transitions is something like a startup animation. You wait for the first frame (either the first frame at load or after BFCache-restore) using the
pagereveal
event. I'd say it would also be the appropriate place to do something like reporting a page view.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand this now, and have added it to the page.