Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for message fragmentation to handle large messages #34154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ashish-CodeJourney
Copy link
Contributor

Description

Implemented message fragmentation to support the transmission of large messages by splitting them into smaller chunks. This enhancement ensures compatibility with systems that have strict size limits on individual messages, improving the overall reliability of the messaging system.

Motivation

The primary motivation behind these changes is to address the limitation where messages exceeding a predefined size limit could not be transmitted due to size restrictions on the receiving end. By introducing message fragmentation, we enable the successful transmission of all messages, regardless of their size, thereby enhancing the robustness and flexibility of our messaging system.

Additional details

This implementation is based on the understanding that many applications and services impose strict size constraints on incoming messages. By allowing messages to be split into smaller chunks and then reassembled on the receiving end, we ensure broader compatibility and improved performance in scenarios involving large data transfers.

Related issues and pull requests

Fixes #34151

@Ashish-CodeJourney Ashish-CodeJourney requested a review from a team as a code owner June 14, 2024 09:44
@Ashish-CodeJourney Ashish-CodeJourney requested review from jpmedley and removed request for a team June 14, 2024 09:44
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed labels Jun 14, 2024
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Preview URLs

(comment last updated: 2024-07-13 12:12:20)

@Ashish-CodeJourney
Copy link
Contributor Author

it looks like @jpmedley is not active from a long time
@Josh-Cena can you please look into this PR and my other PRs where he is assigned as a reviewer ?

@Josh-Cena
Copy link
Member

This is very related to #29104 where @rebloor seems to hit a similar error as #34151. I'm going to add them as a reviewer.

@Josh-Cena Josh-Cena requested a review from rebloor June 19, 2024 09:17
@Ashish-CodeJourney
Copy link
Contributor Author

This is very related to #29104 where @rebloor seems to hit a similar error as #34151. I'm going to add them as a reviewer.

Thanks

@Ashish-CodeJourney
Copy link
Contributor Author

@rebloor does this sounds fine ?

@rebloor rebloor requested a review from dotproto June 21, 2024 19:12
@rebloor
Copy link
Contributor

rebloor commented Jun 21, 2024

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

@Ashish-CodeJourney
Copy link
Contributor Author

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

Okay, let's wait for his review

@Ashish-CodeJourney
Copy link
Contributor Author

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

Okay, let's wait for his review

@

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

Okay, let's wait for his review

@rebloor @dotproto any updates ?

@dotproto
Copy link
Collaborator

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

@Ashish-CodeJourney
Copy link
Contributor Author

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

Makes sense.
let me know if you need me to update anything in this

@Ashish-CodeJourney
Copy link
Contributor Author

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

Makes sense. let me know if you need me to update anything in this

@dotproto any updates ?

@Ashish-CodeJourney
Copy link
Contributor Author

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

Makes sense. let me know if you need me to update anything in this

@dotproto any updates ?

@dotproto @rebloor ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native messaging example with python 3.12.4 does not work
4 participants