-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for message fragmentation to handle large messages #34154
Conversation
Preview URLs (comment last updated: 2024-07-13 12:12:20) |
it looks like @jpmedley is not active from a long time |
@rebloor does this sounds fine ? |
@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test. |
Okay, let's wait for his review |
@
|
I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main. |
Makes sense. |
@rebloor @dotproto @Josh-Cena it's open since 4 - 5 months |
Description
Implemented message fragmentation to support the transmission of large messages by splitting them into smaller chunks. This enhancement ensures compatibility with systems that have strict size limits on individual messages, improving the overall reliability of the messaging system.
Motivation
The primary motivation behind these changes is to address the limitation where messages exceeding a predefined size limit could not be transmitted due to size restrictions on the receiving end. By introducing message fragmentation, we enable the successful transmission of all messages, regardless of their size, thereby enhancing the robustness and flexibility of our messaging system.
Additional details
This implementation is based on the understanding that many applications and services impose strict size constraints on incoming messages. By allowing messages to be split into smaller chunks and then reassembled on the receiving end, we ensure broader compatibility and improved performance in scenarios involving large data transfers.
Related issues and pull requests
Fixes #34151