Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for message fragmentation to handle large messages #34154

Closed
wants to merge 2 commits into from
Closed

Add support for message fragmentation to handle large messages #34154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b2475b
Implement message fragmentation for large messages
Ashish-CodeJourney Jun 14, 2024
23d49f7
Merge branch 'main' into feature/34151
Ashish-CodeJourney Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions files/en-us/mozilla/add-ons/webextensions/native_messaging/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,19 @@ import struct

# Read a message from stdin and decode it.
def getMessage():
rawLength = sys.stdin.buffer.read(4)
if len(rawLength) == 0:
sys.exit(0)
messageLength = struct.unpack('@I', rawLength)[0]
message = sys.stdin.buffer.read(messageLength).decode('utf-8')
totalLength = 0
messageParts = []
while True:
rawLength = sys.stdin.buffer.read(4)
if len(rawLength) == 0:
break
messageLength = struct.unpack('@I', rawLength)[0]
part = sys.stdin.buffer.read(messageLength).decode('utf-8')
messageParts.append(part)
totalLength += messageLength
if totalLength >= MAX_MESSAGE_SIZE:
break
message = ''.join(messageParts)
return json.loads(message)

# Encode a message for transmission,
Expand All @@ -360,10 +368,25 @@ def encodeMessage(messageContent):
return {'length': encodedLength, 'content': encodedContent}

# Send an encoded message to stdout
MAX_MESSAGE_SIZE = 1024 # Maximum message size in bytes

def sendMessage(encodedMessage):
sys.stdout.buffer.write(encodedMessage['length'])
sys.stdout.buffer.write(encodedMessage['content'])
sys.stdout.buffer.flush()
messageSize = len(encodedMessage['content'])
if messageSize > MAX_MESSAGE_SIZE:
# Split the message into chunks and send each chunk separately
chunkSize = MAX_MESSAGE_SIZE
numChunks = (messageSize + chunkSize - 1) // chunkSize
for i in range(numChunks):
start = i * chunkSize
end = min(start + chunkSize, messageSize)
chunk = encodedMessage['content'][start:end]
sys.stdout.buffer.write(struct.pack('@I', len(chunk)))
sys.stdout.buffer.write(chunk)
sys.stdout.buffer.flush()
else:
sys.stdout.buffer.write(encodedMessage['length'])
sys.stdout.buffer.write(encodedMessage['content'])
sys.stdout.buffer.flush()

while True:
receivedMessage = getMessage()
Expand Down