Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] add media-query translation #14164

Merged
merged 5 commits into from
Aug 1, 2023
Merged

[ko] add media-query translation #14164

merged 5 commits into from
Aug 1, 2023

Conversation

rbals0445
Copy link
Contributor

@rbals0445 rbals0445 commented Jul 12, 2023

Description

  • 반말로 되어있는 부분들을 존댓말로 수정했습니다.
  • 누락되어 있는 부분을 추가하고, 번역이 어색하게 된 부분을 수정했습니다.
  • 예제가 잘못되어 있는 부분들을 수정했습니다.

Motivation

Additional details

  • yarn run fix:md 를 했는데도 code block 부분에 indent가 조금 다르게 나오네요.. ㅠ

Related issues and pull requests

@rbals0445 rbals0445 requested a review from a team as a code owner July 12, 2023 16:22
@rbals0445 rbals0445 requested review from swimjiy and removed request for a team July 12, 2023 16:22
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Preview URLs (7 pages)
Flaws (675)

URL: /ko/docs/Learn/Server-side/First_steps/Client-Server_overview
Title: Client-Server overview
Flaw count: 110

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 103 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /ko/docs/Tools/Network_Monitor

URL: /ko/docs/Learn/Server-side/Django/Forms
Title: Django 튜토리얼 파트 9: 폼(form)으로 작업하기
Flaw count: 118

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 108 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Learn/HTML/Forms
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Learn/Server-side/Django/Home_page
Title: Django Tutorial Part 5: Creating our home page
Flaw count: 114

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 103 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 1 more flaws omitted

URL: /ko/docs/Learn/Server-side/Django/Authentication
Title: Django Tutorial Part 8: User authentication and permissions
Flaw count: 111

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 106 more flaws omitted

URL: /ko/docs/Learn/CSS/CSS_layout/Media_queries
Title: 미디어 쿼리 초보자 안내서
Flaw count: 111

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 103 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Web/CSS/Media_Queries/Using_media_queries#Media_features
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Learn/CSS/Building_blocks/Selectors/Attribute_selectors
Title: 속성 선택자
Flaw count: 109

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 103 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/Events/Creating_and_triggering_events
Title: 이벤트 생성 및 트리거
Flaw count: 2

  • macros:
    • /ko/docs/Web/API/Event/createEvent redirects to /ko/docs/Web/API/Document/createEvent
    • /ko/docs/Web/API/Event/initEvent does not exist but fell back to /en-US/docs/Web/API/Event/initEvent
External URLs (2)

URL: /ko/docs/Learn/CSS/CSS_layout/Media_queries
Title: 미디어 쿼리 초보자 안내서

(comment last updated: 2023-08-01 13:52:45)

@rbals0445
Copy link
Contributor Author

rbals0445 commented Jul 12, 2023

media type에서 en만 speech 가 없더라구요. (다른 나라는 다 있습니다)
한국도 똑같이 없애야 하지 않나 싶습니다. 아래는 이유입니다!

en ko
image image
  1. 2021년 12.25 �w3c 문서 기준으로 3개만 나와있습니다. 그리고 speech는 반드시 매치가 되어야 하는 속성은 아니라고 나와있습니다.
  1. mdn en 측에 달린 링크에도 2023년 기준 speech가 없는것을 알 수 있습니다.

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 31, 2023
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @rbals0445님, 우선 기여 감사합니다:)
전반적으로는 잘 반영해주신 것 같습니다.
아직 존댓말로 바뀌지 않은 부분이나, 오탈자 등에 대해 코멘트 남겼으니 편하게 확인 부탁드립니다.

files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
files/ko/learn/css/css_layout/media_queries/index.md Outdated Show resolved Hide resolved
@rbals0445
Copy link
Contributor Author

rbals0445 commented Aug 1, 2023

@swimjiy 님 안녕하세요. 리뷰 감사합니다.

리뷰 주신 부분은 모두 수정했고, 따로 띄어쓰기 검사 후 다시 올렸습니다.

과거에 올렸던 PR들은 검증할때 맞춤법 검사기를 돌리지 않아 생긴 문제가 좀 많네요.

번거롭게 해드려 죄송합니다! 다음 작성 PR부터는 전체 검증 후 올리겠습니다!

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Aug 1, 2023
@swimjiy
Copy link
Member

swimjiy commented Aug 1, 2023

@swimjiy 님 안녕하세요. 리뷰 감사합니다.

리뷰 주신 부분은 모두 수정했고, 따로 띄어쓰기 검사 후 다시 올렸습니다.

과거에 올렸던 PR들은 검증할때 맞춤법 검사기를 돌리지 않아 생긴 문제가 좀 많네요.

번거롭게 해드려 죄송합니다! 다음 작성 PR부터는 전체 검증 후 올리겠습니다!

빠른 확인 감사합니다! 잘 반영해주신 것 같아 머지 진행하도록 하겠습니다:)

@swimjiy swimjiy merged commit ed9112e into mdn:main Aug 1, 2023
9 checks passed
@rbals0445 rbals0445 deleted the ko/media-query branch August 1, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants