Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create author form #24261

Closed
wants to merge 53 commits into from
Closed

Update create author form #24261

wants to merge 53 commits into from

Conversation

ikenk
Copy link
Contributor

@ikenk ikenk commented Oct 27, 2024

Description

Motivation

To update the create_author_form doc

Additional details

Related issues and pull requests

@ikenk ikenk requested a review from a team as a code owner October 27, 2024 16:28
@ikenk ikenk requested review from jasonren0403 and removed request for a team October 27, 2024 16:28
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Oct 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 27, 2024 •
edited
Loading

Preview URLs

Flaws (31)

URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/forms/Create_author_form
Title: 创建作者表单
Flaw count: 15

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 10 more flaws omitted

URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/forms/Create_genre_form
Title: 创建种类表单
Flaw count: 16

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
    • and 10 more flaws omitted
  • images:
    • File not present on disk, an empty file, or not an image
External URLs (2)

URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/forms/Create_genre_form
Title: 创建种类表单

(comment last updated: 2024-10-31 16:42:04)

Yanko1013
Yanko1013 reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Yanko1013 Yanko1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些建议：

files/zh-cn/learn/server-side/express_nodejs/forms/create_author_form/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/server-side/express_nodejs/forms/create_author_form/index.md Outdated Show resolved Hide resolved
files/zh-cn/learn/server-side/express_nodejs/forms/create_genre_form/index.md Show resolved Hide resolved
files/zh-cn/learn/server-side/express_nodejs/forms/create_genre_form/index.md

> [!NOTE]
> 我们的验证使用`trim()`，来确保不接受空格作为种类名称。我们还可以在表单中 的字段定义中，添加值`required='true'`，来验证客户端字段不为空：
> 我们的验证使用 `trim()` 来确保不接受空格作为种类名称。我们还对表单中​​字段定义添加 `required` ![布尔属性](/zh-CN/docs/Glossary/Boolean/HTML)来验证客户端上的字段不为空：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应当移除!，否则为引用图片。

yin1999
yin1999 requested changes Oct 29, 2024
View reviewed changes
files/zh-cn/learn/server-side/express_nodejs/forms/create_genre_form/index.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请移除这个文档的修改（相关的修改已在 #24220 中体现）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你说的这个应该不用我来处理吧？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要，请清理一下当前 PR 的提交。里面混入了很多 rebase 后产生的无效提交内容。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对不起，我也不知道这次是怎么回事，从本地提交到github的时候总在提示我冲突，我只好先在fork的仓库里把所有的分支都同步到和mdn仓库一致，然后再git pull --rebase进本地分支，最后再git push，但是git push之后就多出了很多别人的pr记录。
我其实很困惑为什么我在fork的仓库里sync的时候会把pr也包含进来。
如果可以的话我就重开一个pr，这样省事一点

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重新开吧，请避免修改 fork 仓库的主分支（主分支只用于和上游同步），有内容需要反馈到上游时请始终新建分支，然后只在分支中做修改）。常见的内容修改涉及的分支也请使用 git merge 命令来更新分支（用 git rebase 会导致审查人员的审查进度被重置）。

mdn-bot and others added 21 commits November 1, 2024 00:37
@mdn-bot @ikenk
[ko] sync translated content (mdn#24211)
0361fd6 
ko: sync translated content
@hoel44 @ikenk
Update index.md one missing word in french translation (mdn#24210)
bf2f288 
Update index.md

French translation, one missing word added in the sentence.
Traduction française, un mot manquant ajouté dans la phrase.
@FacuBotta @ikenk
Typofix for Notions de base en HTML: "Comment ..." => "Comme ..." (md…
ffe7b26 
…n#24215)

Update index.md

Correction in line 125. "Comment ..." => "Comme ..."
@SphinxKnight @ikenk
Fix mdn#23755 (mdn#23964)
4e39cc2 
* Update per en-US to fix mdn#23755

* Typofix / missing translation
@hiroya-uga @ikenk
[ja] sync translated content
626f1d0
@mfuji09 @ikenk
2024/10/02 時点の英語版に基づき更新
477c80e
@mfuji09 @ikenk
2024/10/09 時点の英語版に基づき更新
d342e38
@mfuji09 @ikenk
2024/09/05 時点の英語版に基づき新規翻訳
93fd572
@mfuji09 @ikenk
2024/09/29 時点の英語版に基づき更新
9c2f0a6
@mfuji09 @ikenk
2024/09/27 時点の英語版に基づき更新
f4c973d
@mfuji09 @ikenk
2024/09/27 時点の英語版に基づき更新
0300a7c
@mfuji09 @ikenk
2024/09/23 時点の英語版に基づき更新 (mdn#24158)
a07f88b 
* 2024/09/23 時点の英語版に基づき更新

* Update index.md
@mfuji09 @ikenk
2024/10/11 時点の英語版に基づき更新
9ada812
@mfuji09 @ikenk
2024/10/16 時点の英語版に基づき更新
fb126c8
@mfuji09 @ikenk
2024/04/17 時点の英語版に基づき新規翻訳
8adde34
@mfuji09 @ikenk
2024/10/09 時点の英語版に基づき更新 (mdn#24167)
6fdde6f 
* 2024/10/09 時点の英語版に基づき更新

* Update index.md
@mfuji09 @ikenk
2024/07/26 時点の英語版に基づき新規翻訳
92309a5
@mfuji09 @ikenk
2024/10/15 時点の英語版に基づき更新
e977d5d
@mfuji09 @ikenk
2024/10/11 時点の英語版に基づき更新
c45fba9
@rafael-encinas @ikenk
[es] Add missing 'element copy event' page (mdn#24223)
27956bd 
* Add missing 'element copy event' page

* Update files/es/web/api/element/copy_event/index.md

* Update files/es/web/api/element/copy_event/index.md

Borrar espacio en blanco de más

* Update files/es/web/api/element/copy_event/index.md

Borrar linea vacía
@Yanko1013 @ikenk
[zh-cn]: fix sidebar missing for Web/Performance/* (mdn#24224)
f277a06
@ikenk ikenk requested review from hochan222, mfuji09 and SphinxKnight and removed request for a team October 31, 2024 16:37
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. system Infrastructure and configuration for the project labels Oct 31, 2024
@github-actions github-actions bot removed l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. system Infrastructure and configuration for the project labels Oct 31, 2024
@mfuji09 mfuji09 removed their request for review October 31, 2024 16:44
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@yin1999 yin1999 closed this Nov 1, 2024
@ikenk
Copy link
Contributor Author

ikenk commented Nov 1, 2024 via email

@ikenk ikenk deleted the update-create_author_form branch November 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yanko1013 Yanko1013 Yanko1013 left review comments

@yin1999 yin1999 yin1999 requested changes

@jasonren0403 jasonren0403 Awaiting requested review from jasonren0403 jasonren0403 is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content. merge conflicts 🚧 This pull request has merge conflicts that must be resolved.
Projects
MDN translated-content l10n-zh
Status: Archive/Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.