Remove IndepVarComp from heat exchanger model so users can connect things to the DV values #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The heat exchanger model previously had an independent variable component connected to most inputs, such as channel geometry, number of channels in each dimension, etc. This prevented users from connecting outputs from other components to these inputs in the heat exchanger model. This fix removes the independent variable component and instead uses OpenMDAO's
set_input_defaults
. This means OpenMDAO will automatically connect anIndepVarComp
with these values if nothing is connected by the user.This change also allows the removal of the copy of all
HXGroup
's internals into the heat exchanger test script.Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.