Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IndepVarComp from heat exchanger model so users can connect things to the DV values #61

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

eytanadler
Copy link
Collaborator

Purpose

The heat exchanger model previously had an independent variable component connected to most inputs, such as channel geometry, number of channels in each dimension, etc. This prevented users from connecting outputs from other components to these inputs in the heat exchanger model. This fix removes the independent variable component and instead uses OpenMDAO's set_input_defaults. This means OpenMDAO will automatically connect an IndepVarComp with these values if nothing is connected by the user.

This change also allows the removal of the copy of all HXGroup's internals into the heat exchanger test script.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Refactoring (no functional changes, no API changes)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dc5d69) 79.95% compared to head (3c7d7e1) 79.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   79.95%   79.95%   -0.01%     
==========================================
  Files          85       85              
  Lines        9301     9300       -1     
==========================================
- Hits         7437     7436       -1     
  Misses       1864     1864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariejvaucher mariejvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@mariejvaucher mariejvaucher merged commit 6fc0a1c into mdolab:main Feb 14, 2024
13 checks passed
@eytanadler eytanadler deleted the remove_hx_ivc branch February 14, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants