error handling on mphys pygeo 'type'

[gawng]

Purpose

This places an else check on the info['type'] because I kept passing in type keyword argument as uppercase 'FFD' when it was looking for lowercase 'ffd'. Now at least the warning message will tell the user what is breaking.

Expected time until merged

Relatively simple so maybe a few days?

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

I ran it locally passing in 'FFD' and it returned an error instead of proceeding.

Checklist

• I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
• I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.01%. Comparing base (ba45e83) to head (e601e72).

Files with missing lines	Patch %	Lines
pygeo/mphys/mphys_dvgeo.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   67.02%   67.01%   -0.01%     
==========================================
  Files          47       47              
  Lines       12326    12327       +1     
==========================================
  Hits         8261     8261              
- Misses       4065     4066       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marcomangano]

This looks good, but what if we cast info["type"] to lower case by default, maybe here? Not sure if that reflect best coding practices though

[gawng]

We could certainly do that. I don't know if that is the best spot to cast to lower case because I think using DVGeoMulti may bypass that. I just figured that the else catch is a more robust catch for the type of error I was falling into.

[A-CGray]

Why not check the equality using info["type"].lower()? That way it's case insensitive.