Match labels

[mshitrit]

In order to solve ECOPROJECT-1307 using and matching unique labels in DS

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mshitrit]

/test ?

[openshift-ci]

@mshitrit: The following commands are available to trigger required jobs:

• /test 4.11-ci-index-self-node-remediation-bundle
• /test 4.11-images
• /test 4.11-openshift-e2e
• /test 4.11-test
• /test 4.12-ci-index-self-node-remediation-bundle
• /test 4.12-images
• /test 4.12-openshift-e2e
• /test 4.12-test
• /test 4.13-ci-index-self-node-remediation-bundle
• /test 4.13-images
• /test 4.13-openshift-e2e
• /test 4.13-test
• /test 4.14-ci-index-self-node-remediation-bundle
• /test 4.14-images
• /test 4.14-openshift-e2e
• /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e

[razo7]

IIUC the suggested changes, then we should update the label in few more places:
SNR:

• https://github.com/medik8s/self-node-remediation/blob/main/pkg/utils/pods.go#L17
• https://github.com/medik8s/self-node-remediation/blob/main/controllers/selfnoderemediation_controller_test.go#L546
• https://github.com/medik8s/self-node-remediation/blob/main/controllers/selfnoderemediation_controller_test.go#L570
  NHC
• https://github.com/medik8s/node-healthcheck-operator/blob/main/.github/workflows/pre-submit.yaml#L173-L175

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.12-openshift-e2e
/test 4.13-openshift-e2e
/test 4.14-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e
/test 4.14-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e
/test 4.14-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e
/test 4.14-openshift-e2e

[mshitrit]

/test 4.13-openshift-e2e

[slintes]

Wouldn't it make sense to add this to the place where we already deal with the Daemonset? 🤔

https://github.com/medik8s/self-node-remediation/blob/main/controllers/selfnoderemediationconfig_controller.go#L102

edit: "this" refers to the last commit with old DS deletion

[mshitrit]

/test 4.13-openshift-e2e

[mshitrit]

/test 4.12-openshift-e2e

[mshitrit]

/test 4.12-openshift-e2e

[slintes]

I would reorder things in the removeOldDsOnUpdateOperator() a bit (error handling first, then the happy path), but I won't block on this. Btw, why Operator in the method name?

Can we have a unit test for this?

[mshitrit]

I would reorder things in the removeOldDsOnUpdateOperator() a bit (error handling first, then the happy path),

Yep, I agree it would make more sense

Btw, why Operator in the method name?

IIUC this use case is relevant for when the operator is updated, just "update" seemed very generic to me and I wasn't sure the context will be clear enough

Can we have a unit test for this?

Indeed, good point.

[slintes]

IIUC this use case is relevant for when the operator is updated, just "update" seemed very generic to me and I wasn't sure the context will be clear enough

Ah ok, makes sense. Maybe removeOldDsOnOperatorUpdate() is a bit less confusing? 🙂

[mshitrit]

/test 4.12-openshift-e2e

[slintes]

nice test 👍🏼

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mshitrit,slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment