Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.13: Add remote federated search documentation #3144

Merged
merged 14 commits into from
Feb 13, 2025
Merged

v1.13: Add remote federated search documentation #3144

merged 14 commits into from
Feb 13, 2025
+487 −37

Conversation

guimachiavelli
Copy link
Member

Closes #3136

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:v1.13-proxy-search

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli mentioned this pull request Feb 4, 2025
Open
@guimachiavelli guimachiavelli changed the title add /network documentation v1.13L Add remote federated search documentation Feb 4, 2025
@guimachiavelli guimachiavelli changed the title v1.13L Add remote federated search documentation v1.13: Add remote federated search documentation Feb 4, 2025
@guimachiavelli guimachiavelli mentioned this pull request Feb 6, 2025
Open
@guimachiavelli guimachiavelli marked this pull request as ready for review February 6, 2025 18:33
@guimachiavelli guimachiavelli requested a review from a team as a code owner February 6, 2025 18:33
@guimachiavelli guimachiavelli linked an issue Feb 6, 2025 that may be closed by this pull request
v1.13: Proxy search requests #3136
Open
12 tasks
@guimachiavelli guimachiavelli added this to the v1.13 milestone Feb 10, 2025
dureuill
dureuill reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, I made a few inline comments.

I couldn't find the security notice I added to the API usage page. I think it is important to have it at a relevant location.

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
learn/multi_search/implement_sharding.mdx Outdated Show resolved Hide resolved
learn/multi_search/implement_sharding.mdx Outdated Show resolved Hide resolved
reference/api/multi_search.mdx Outdated Show resolved Hide resolved
guimachiavelli
guimachiavelli commented Feb 12, 2025
View reviewed changes
learn/multi_search/implement_sharding.mdx Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
curquiza
curquiza approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for code samples

dureuill
dureuill approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you gui :-)

macraig
macraig approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@macraig macraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reactivity @guimachiavelli ! 🙏

@guimachiavelli guimachiavelli merged commit bb95398 into v1.13 Feb 13, 2025
3 checks passed
@guimachiavelli guimachiavelli deleted the v1.13-proxy-search branch February 13, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubus mdubus mdubus left review comments

@macraig macraig macraig approved these changes

@curquiza curquiza curquiza approved these changes

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Code sample changes
Status: No status
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

v1.13: Proxy search requests
6 participants
@guimachiavelli @meili-bot @macraig @curquiza @mdubus @dureuill