Add mattb325:commercial-collection and mattb325:commercial-w2w-collection
#46
Conversation
|
@memo33 I've given this one the dependency treatment as well. It's the usual suspects that got eliminated as with the other packages. I'd say this is ready for review now. I've also added both the darknite and maxisnite urls. I would also like to add the Simtropolis urls where possible - so that it will show a button "Install with sc4pac" on the STEX as well for those ones that are available there too, but I'm still looking for a way to automate this. Matt has way too many content on the STEX (15 pages!) to do all of this manually. I'll keep this for a separate PR. |
|
I've found a way to automate a large part of it, converting back to draft so that I can include it. |
|
Allright, I added a bunch of websites. I'm probably going to add all of mattb325's content that's on the STEX as well, and then I'll look for duplicate files to figure out which ones were already included in the SC4E legacy packs. |
|
@memo33 Is there anything holding this back from getting merged? I'm currently backfilling matt's missing content in the Simtropolis channel, so it would be useful to have this merged so that the ST channel detects what content is already available in the default channel. |
sebamarynissen
changed the title
mattb325:commercial-pack and mattb325:commercial-w2w-packmattb325:commercial-collection and mattb325:commercial-w2w-collection
memo33
force-pushed
the
feature/mattb-commerical
branch
from
a4ec25c to
485db4b
Compare
|
Thank you. |
We've removed a bunch of packages that are already available in memo33/sc4pac#46
* Add page 1 * Don't process packages already available * Allow overriding local packages * Add page 2 * Update 18253-blam-overpath-props-volume-1.yaml * Update sc4d.js * Create 29148-london-bridge-quarter-the-shard-and-place.yaml * Add `xyloxadoria:6th-and-brushy` * Esnure simfox day-and-nite is not included * Add page 3 * Remove diggis ponds in favor of default channel * Update sc4d.js * Add page 4 * Create 34230-chinatown-road-avenue-and-pedestrian-lane-canopies.yaml * Add page 5 * Update sc4d.js * Add page 6 * Add page 7 * Update parse-dependencies.js * Add page 8 * Add page 9 * Add page 10 * Add page 11 * Add page 12 * Create 31893-car-ferry-terminal.yaml * Update 31893-car-ferry-terminal.yaml * Add page 13 * Add page 14 * Add page 15 * Create 27975-old-market-hall.yaml * Fix missing subfolders * Improve auto-detection of maxis and dark nite * Fix MN/DN variants * Fix MN/DN * Fix model path too long * Fix duplicate pwn-london * Remove duplicates We've removed a bunch of packages that are also included in memo33/sc4pac#47, so no need to put them on the ST channel too. * Include filename when traversing * Remove duplicates We've removed a bunch of packages that are already available in memo33/sc4pac#46 * Remove duplicate * Update sc4d.js * Remove duplicates Some packages were removed that are already present on the default channel. * Fix exclusion pattern * Delete 33006-diagonal-rail-glr-bus-and-subway-stations.yaml * Add scripts for finding duplicates
This PR adds mattb325's commercial pack and commercial w2w pack.
One thing to note: the
spar-distribution-cspackage is bugged on SC4Evermore because it includes and I-HT desc, while the lot references another desc file. I will notify the SC4E staff about this, but I've been able to fix it in this package by using the files from Simtropolis instead.