-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(state): add from, to ids for edge #5503
feat(state): add from, to ids for edge #5503
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5503 +/- ##
=======================================
Coverage 5.73% 5.73%
=======================================
Files 277 277
Lines 41999 42033 +34
Branches 515 515
=======================================
+ Hits 2407 2409 +2
- Misses 39592 39624 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
feat(state): add from, to ids for edge
feat(state): add from, to ids for edge
feat(state): add from, to ids for edge
@igorwessel, Thank you for the contribution! |
@sidharthv96 could we include it in a minor release? I can do a double-check and look to see if any breaking changes were introduced. |
Current develop has breaking changes, slotted for v11. So we'll have to extract your changes and rebase onto master to make a new release. We are only doing v10 security releases now. |
@sidharthv96 is there an RC version that we can use to unblock and test these changes ? |
@sidharthv96 I realized that this modification was not in the release, I will open a PR again by inserting the IDs. 😆 |
Everything that was merged should have been out in v11 release. I'm on my mobile rn, so can't check what happened. |
📑 Summary
The ID of the from-to relationship was added to the diagram's edges.
Another denominator "_" was used to make the extraction of these respective IDs easier.
📏 Design Decisions
I am currently working on converting state diagram to Excalidraw, and I felt the need to have an easier way to find the edges.
I tried some alternative paths but without success, for example:
.edgePaths
, however, the index does not always reflect how we iterate through the parser.doc.graphCount
id to get the edge, but in cases where we have multiple relationships for the same state, it may not find the correct edge because we do not have access to thegraphCount
in the parser.doc, only to the node id.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch