refactor: use icon component instead of svg code (part-1) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unimu-cic
force-pushed
the
refactor/use-icon-component-instead-of-svg-codes-part-1
branch
from
3f226d3 to
5ba7f4f
Compare
MrCoder
reviewed
Sep 18, 2023
| fill="currentColor"></path> | ||
| </svg> | ||
| <button class="bottom-1 flex items-center left-1 hide-export" @click="showTipsDialog()"> | ||
| <Icon icon-class="filter grayscale w-4 h-4" name="tip"/> |
There was a problem hiding this comment.
Probably move name to the first position of attributes to improve readability. It is not a blocker for this PR.
MrCoder
reviewed
Sep 18, 2023
@MrCoder Updated: https://github.com/mermaid-js/zenuml-core/pull/59/files#diff-df2bce34943c604a94a8d490b30b10392f1f6eefb28690e7482a45704fd02664, some files still exist inline SVG code, will replace them in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.