Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use icon component instead of svg code (part-1) #59

Merged
merged 3 commits into from
Sep 19, 2023
Merged

refactor: use icon component instead of svg code (part-1) #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db5a18f
feat: add icon svg assets
unimu-cic Sep 17, 2023
ed7270f
chore: add `vite-svg-loader`
unimu-cic Sep 17, 2023
5ba7f4f
feat: use `Icon` components instead of svg files
unimu-cic Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"typescript": "^4.7.4",
"vite": "^3.2.3",
"vite-plugin-css-injected-by-js": "^2.2.0",
"vite-svg-loader": "^4.0.0",
"vitest": "^0.26.1"
},
"eslintConfig": {
Expand Down
150 changes: 128 additions & 22 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 4 additions & 14 deletions src/components/DiagramFrame/Debug/Debug.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,21 @@
<div
class="ml-4 text-xs inline-flex items-center font-bold leading-sm px-3 py-1 bg-green-200 text-green-700 rounded-sm"
>
<svg
class="h-4 w-4"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<line x1="6" y1="3" x2="6" y2="15"></line>
<circle cx="18" cy="6" r="3"></circle>
<circle cx="6" cy="18" r="3"></circle>
<path d="M18 9a9 9 0 0 1-9 9"></path>
</svg>
<Icon name="debug" icon-class="h-4 w-4" />
<span class="inline-block px-2">{{ gitBranch }}:{{ commitHash }}</span>
</div>
</div>
</div>
</template>

<script>
import Icon from "@/components/Icon/Icon.vue";

const commitHash = 'process.env.VUE_APP_GIT_HASH';
const gitBranch = 'process.env.VUE_APP_GIT_BRANCH';
export default {
name: 'Debug',
components: {Icon},
data() {
return {
commitHash,
Expand Down
Loading