Allow root meson.build files to be symlinks #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei8l
reviewed
Nov 29, 2023
| @@ -198,7 +198,7 @@ export async function mesonRootDirs(): Promise<string[]> { | |||
| let hasMesonFile: boolean = false; | |||
| let subdirs: vscode.Uri[] = []; | |||
| for (const [name, type] of await vscode.workspace.fs.readDirectory(d)) { | |||
| if (type === vscode.FileType.File && name == "meson.build") { | |||
| if ((type === vscode.FileType.File || type === vscode.FileType.SymbolicLink) && name == "meson.build") { | |||
There was a problem hiding this comment.
Suggested change
| if ((type === vscode.FileType.File || type === vscode.FileType.SymbolicLink) && name == "meson.build") { | |
| if ((type === vscode.FileType.File || type === (vscode.FileType.File | vscode.FileType.SymbolicLink)) && name == "meson.build") { |
AFAICT this is the correct check. Based on this sample, and the debugger showing type is 65 for symlinked files.
There was a problem hiding this comment.
Makes sense. Can you submit a PR? I'll cook up a release tomorrow. Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207