E2E: add announcement tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Paolinelli <[email protected]>
Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
moretests
branch
2 times, most recently
from
acb9fb1
to
aa5ecc8
Compare
oribon
reviewed
Jul 13, 2023
| ValidatePrefixesForNeighbor(f, nodes, "fc00:f853:ccd:e799::/64", "fc00:f853:ccd:e800::/64") | ||
| } | ||
| }, | ||
| }), |
There was a problem hiding this comment.
can we add a dual case at this point or not yet?
oribon
reviewed
Jul 16, 2023
Comment on lines
+33
to
+34
| var notFound RouteNotFoundError | ||
| if errors.As(err, ¬Found) { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
Because the specific error is different from a conversion error or something not recoverable.
Even though routeForCIDR can only return that type of error, it's better to handle the specific error separately from the generic one, it will make the logic future proof.
e2etests/pkg/routes/routes.go
Outdated
| return frr.Route{}, RouteNotFoundError(fmt.Sprintf("route %s not found", cidr)) | ||
| } | ||
|
|
||
| func havePrefix(pod *v1.Pod, pairingFamily ipfamily.Family, prefix *net.IPNet, nextHop, vrf string) bool { |
There was a problem hiding this comment.
yep, I reworked a lot of the logic in the "incoming prefixes" PR and backported the files, this sneaked in. Removing
e2etests/tests/advertisement.go
Outdated
| } | ||
| }, | ||
| }), | ||
| ginkgo.Entry("DUAL - Advertise with mode allowall", params{ |
There was a problem hiding this comment.
DUAL -> DUALSTACK as that is what we skip in the ci? (although this passes on these lanes)
We add basic announcement tests where all the nodes announce the same ips to all / some neighbors. Signed-off-by: Federico Paolinelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add basic announcement tests where all the nodes announce the same
ips to all / some neighbors.