-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New interface reader #976
New interface reader #976
Conversation
… is found for a station
…t the same time as a config
… Station object, and use that as metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Some clean up needed and I have some questions about introducing dependencies and whether you're planning on introducing pickle files into CI. Overall this is really cool to see, and would be great to include. I also see there are some notes-to-self about things to do. Many of those things you've marked as TODO would be great to include in this PR if you think it's possible. Nice work!
pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth talking about introducing a dependency. It seems like a solid one and a good choice though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test fail, reverting approve
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #976 +/- ##
============================================
+ Coverage 78.97% 79.84% +0.86%
============================================
Files 106 108 +2
Lines 18489 18831 +342
============================================
+ Hits 14602 15035 +433
+ Misses 3887 3796 -91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 🦄 🌟
Pyaro integration