Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thing to note, although i was successful with my code. However, I'm still a bit clueless to the original demo code.
And since I don't want to introduce my own personal code and I think the already existing template is very informative, I've decided to try and keep everything as close to the original as possible.
The current error is the following:
How is the linker supposed to associate the udp_transport_threadX with microros_transports.h / what causes the linker to fetch the implementation for all those symbols inside <udp_transport...>?
Also i get submodules and everything but on the demos i personally thing ommiting the duplicate code on src is really annoying as when people are already 5 hours into modified code they just wanna see the original demo to see what broke and.... its a submodule so you have to clone a massive repo to see it. Im unshure if watching it on vcode developer mode resolves this issue but regardless it might
Also i felt as thought it was cortesy to update the readme but i know it doesnt fit in towards the hole organization of the various repos if any change is needed please let me know(i've had previous annoyances with ros2 and i know that i probably will have to try it on iron/rolling but unfortunately im on arch linux which means installing any version of ros2, unless its from scratch is a real pain in the ass due to all those obsolete dependancies)
I've decided to merge this into humble as although im 99% certain nothing will change from humble to iron, i've tested it with humble, and i've spent all my work and tests on humble so it would be misguided for me to announce that it was working for iron
Also i fixed a minor formatting issue on readme.
I also signed the commit(with gpg, yubikey) ... But unfortunately GitHub doesn't really like my email domain(which despite humorous i treat it as a serious email, due to privacy/ security reasons),
I was unshure if i had to sign it with my real name or just the name i place in the commits, if a real name is required for the apache license please let me know