Re: Sim missing at exactly 991px width from MicroBit repo #9621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoltz
changed the title
jwunderl
approved these changes
Jul 31, 2023
| @@ -166,7 +166,7 @@ namespace pxt.BrowserUtils { | |||
| } | |||
|
|
|||
| export function isTabletSize(): boolean { | |||
| return window?.innerWidth < pxt.BREAKPOINT_TABLET; | |||
| return window?.innerWidth <= pxt.BREAKPOINT_TABLET; | |||
| } | |||
|
|
|||
| export function isComputerSize(): boolean { | |||
There was a problem hiding this comment.
this function already has it >=, so we need to fix that so we never end up with both isTabletSize() === true & isComputerSize() === true at the same time
|
Certainly! |
jwunderl
approved these changes
Aug 1, 2023
|
Sounds great. I will look at other bugs to fix. |
|
(if you want a related one, I believe there is a minor spacing issue still with the download button having extra left margin when in a tutorial 991px width -- this fixed most of the issues related to tutorials at the breakpoint though! This one should be in the |
|
I'll take a look. I'm in Colombia at the moment with limited internet but will fix once I am back in the states. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is concerning issue #5328 in the Microbit repo (microsoft/pxt-microbit#5328). The issue was that the simulator was not showing up when the window width was exactly 991px wide. After a lot of digging I was able to pinpoint that the issue was stemming from the
isTabletSize()function within thebrowserutils.tsfile.to