Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: Sim missing at exactly 991px width from MicroBit repo #9621

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Re: Sim missing at exactly 991px width from MicroBit repo #9621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d434aae
changed:
emoltz Jul 29, 2023
e104f99
changed `isComputerSize` function from >= to >
emoltz Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pxtlib/browserutils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,11 @@ namespace pxt.BrowserUtils {
}

export function isTabletSize(): boolean {
return window?.innerWidth < pxt.BREAKPOINT_TABLET;
return window?.innerWidth <= pxt.BREAKPOINT_TABLET;
}

export function isComputerSize(): boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function already has it >=, so we need to fix that so we never end up with both isTabletSize() === true & isComputerSize() === true at the same time

return window?.innerWidth >= pxt.BREAKPOINT_TABLET;
return window?.innerWidth > pxt.BREAKPOINT_TABLET;
}

export function noSharedLocalStorage(): boolean {
Expand Down
Loading