Refactor all of our various cra build steps #9907
Conversation
| if (pathname == "/--multiplayer") { | ||
| sendFile(path.join(publicDir, 'multiplayer.html')); | ||
| return | ||
| for (const subapp of SUB_WEBAPPS) { |
There was a problem hiding this comment.
GitHub won't let me make comments higher up in the file, but up at line 28, there's a webappNames array we'll need to update for apps that have localServe set to false. Slight quirk in that teachertool's is not actually teachertool, it's "eval". May need add an extra field for publicName or endpointName or something.
There was a problem hiding this comment.
ah, good catch. lemme see what i can do here...
| .pipe(gulp.dest("webapp/public"))); | ||
|
|
||
| const teacherTool = gulp.series(cleanTeacherTool, buildTeacherTool, gulp.series(copyTeacherToolCss, copyTeacherToolJs, copyTeacherToolHtml)); | ||
| const teacherTool = createWebappTasks("teachertool"); |
There was a problem hiding this comment.
Down below here, we have the "webapp build wrapper" section which calls into the update*Strings functions. That could maybe be made slightly simpler with a unified updateWebappStrings function so we don't have to create a new one for each app, but not a huge deal.
| "built/web/teachertool/css/*.css", | ||
| "built/web/teachertool/js/*.js", | ||
| "built/web/*/css/*.css", | ||
| "built/web/*/js/*.js", |
There was a problem hiding this comment.
It'd be nice if we could update the npm-prepare.js script (gets called as a part of prepare at the bottom of this file) to also reference subwebapp.ts but I'm not sure if that's possible...
There was a problem hiding this comment.
done! I moved this config into a json file that gets used in npm-prepare.js, in the cli, and in the gulpfile
|
Maybe not very helpful at this point, but FWIW, I saved a branch which just had the bare-bones updates I needed to make a new CRA. Figured I'd mention it, in case it's a useful reference: master...thsparks/new_react_app#diff-d7ffbddb3a36042f0033638e9e21f556c8873232b040c3f6579488d74adec3daR6 |
I will soon be adding another CRA for the tutorial tool, so I figured it was about time to refactor all of this build code to make it easier to add new apps and generally unify things.
@thsparks since you did this most recently, did I miss anything here?