-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all of our various cra build steps #9907
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
356f344
refactor all of our various cra build steps
riknoll 4e5f4d7
fix referenceerror from import
riknoll 56ba94a
remove webapp names array in server.ts
riknoll fe5e594
move config into json and use in prepare script
riknoll 6490b79
copy config to built and use config for strings
riknoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// All of our various create react apps | ||
export const SUB_WEBAPPS = [ | ||
{ | ||
name: "kiosk", | ||
buildCss: false, | ||
localServe: false | ||
}, | ||
{ | ||
name: "teachertool", | ||
buildCss: false, | ||
localServe: false | ||
}, | ||
{ | ||
name: "skillmap", | ||
buildCss: true, | ||
localServe: true | ||
}, | ||
{ | ||
name: "multiplayer", | ||
buildCss: true, | ||
localServe: true | ||
}, | ||
{ | ||
name: "authcode", | ||
buildCss: true, | ||
localServe: true | ||
}, | ||
]; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub won't let me make comments higher up in the file, but up at line 28, there's a
webappNames
array we'll need to update for apps that have localServe set to false. Slight quirk in that teachertool's is not actually teachertool, it's "eval". May need add an extra field for publicName or endpointName or something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good catch. lemme see what i can do here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!