Datasets: add support for pathlib.Path #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
I think this is finally ready to merge!
First, I want to thank @pioneerHitesh for not giving up on this PR. This was a monumental effort, and I'm sure took way longer than you expected when you signed up to work on #1616 almost a year ago!
Second, I want to thank our CI for testing this PR. I wasn't convinced that older versions of torchvision would support pathlib, and was especially worried about all of our dependencies that lack type hints. But according to CI, all versions of all dependencies magically support pathlib for all purposes we use them for!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1616