Provide an option to hook up DTS emulator when locally debugging DTS projects #4538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
commented
Jun 12, 2025
| public async execute(context: T): Promise<void> { | ||
| const emulatorId: string = nonNullValue( | ||
| await commands.executeCommand('azureFunctions.durableTaskScheduler.startEmulator'), | ||
| localize('failedToStartEmulator', 'Internal error: Failed to start DTS emulator.'), |
There was a problem hiding this comment.
Not sure how important it is for me to add all these failure messages since preDebugValidate will end up swallowing these messages anyway 😆
…ions into mwf/convinced-gray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on feedback before taking out of draft.
General flow for reference:
I made a small deviation - I don't specifically ask the user if they want to "start" the emulator, I just ask them if they want to use an emulator, and I start it automatically if they choose it. This is just because I wanted to see if I could get away with keeping the connection prompts roughly the same between all durable providers. That said, we certainly have the flexibility to improve the wording/prompts to be more explicit about how we're starting the emulator for them, so open to any feedback on that!
Although not yet connected yet, in the future I think we'll want to add some of these predebug tasks into the activity log, in which case we would be able to show the user more transparently that we started the emulator for them. We should also show this in the output log.
Related: https://github.com/microsoft/azcode-internal/issues/212