Use custom node-gyp in product build #179612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Apr 10, 2023
rzhao271
force-pushed
the
rzhao271/product-build
branch
from
8c98083 to
c2b276b
Compare
deepak1556
requested changes
Apr 11, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
The checkout doesn't work as-is because the user should change which directory they're in before running the checkout command. |
deepak1556
reviewed
Apr 12, 2023
Co-authored-by: Robo <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
|
CI build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=210522 |
deepak1556
reviewed
Apr 13, 2023
deepak1556
approved these changes
Apr 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has to do with Binskim.
Upstream is blocked on a CI failure for nodejs/node-gyp#2825, which is blocked on nodejs/gyp-next requiring another release. Even after upstream merges the PR, we would need to wait for a new version of node-gyp to come out.