Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom node-gyp in product build #179612

Merged
merged 13 commits into from
Apr 13, 2023
Merged

Use custom node-gyp in product build #179612

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1fdd0df
Test out win32 product build with custom node-gyp
rzhao271 Apr 5, 2023
509a6b2
Remove exec for now
rzhao271 Apr 5, 2023
1edbb8e
Use absolute path for env config var
rzhao271 Apr 6, 2023
ba42a57
Try adding error msgs to execs
rzhao271 Apr 6, 2023
93434ea
Don't use exec around cd
rzhao271 Apr 6, 2023
3b0b369
Add npm install line
rzhao271 Apr 6, 2023
c2b276b
cd before npm install
rzhao271 Apr 6, 2023
ea757ac
Apply Deepak's suggestion
rzhao271 Apr 11, 2023
76f5126
Copy full SHA
rzhao271 Apr 11, 2023
0652dcf
Fix checkout commands
rzhao271 Apr 11, 2023
939590c
Use workingDirectory instead of cd
rzhao271 Apr 12, 2023
70602ad
Fix relative directory call
rzhao271 Apr 12, 2023
2f3b279
Remove exec around mkdir
rzhao271 Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions build/azure-pipelines/win32/product-build-win32.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,28 @@ steps:
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none'))
displayName: Setup NPM Authentication

- powershell: |
mkdir -Force .build/node-gyp
displayName: Create custom node-gyp directory
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))

- powershell: |
. ../../build/azure-pipelines/win32/exec.ps1
$ErrorActionPreference = "Stop"
# TODO: Should be replaced with upstream URL once https://github.com/nodejs/node-gyp/pull/2825
# gets merged.
exec { git clone https://github.com/rzhao271/node-gyp.git . } "Cloning rzhao271/node-gyp failed"
exec { git checkout 102b347da0c92c29f9c67df22e864e70249cf086 } "Checking out 102b347 failed"
exec { npm install } "Building rzhao271/node-gyp failed"
displayName: Install custom node-gyp
workingDirectory: .build/node-gyp
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))

- powershell: |
. build/azure-pipelines/win32/exec.ps1
. build/azure-pipelines/win32/retry.ps1
$ErrorActionPreference = "Stop"
$env:npm_config_node_gyp="$(Join-Path $pwd.Path '.build/node-gyp/bin/node-gyp.js')"
$env:npm_config_arch="$(VSCODE_ARCH)"
$env:CHILD_CONCURRENCY="1"
retry { exec { yarn --frozen-lockfile --check-files } }
Expand Down