Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix japanese dialog text for creating SymbolicLink, Hardlinks and Jun… #355

Conversation

tokomio-sun
Copy link
Contributor

I fixed some dialog text

[example]
Before:
01_before

After:
02_after

Copy link
Contributor

@clzls clzls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. But I wonder why and when these full width 's came into this file...

@schinagl
Copy link
Contributor

Approve. But I wonder why and when these full width 's came into this file...

This was me, when I introduced symlink creation recently. Google translate gave this to me.

Anyway thx for correcting.

Copy link
Contributor

@clzls clzls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tokomio-sun , there is a full width in Line 420, would you please fix it too?

Edit: and verbs are using different voices across these messages... Maybe 選択している or such is better?

@clzls
Copy link
Contributor

clzls commented Nov 10, 2022

Approve. But I wonder why and when these full width 's came into this file...

This was me, when I introduced symlink creation recently. Google translate gave this to me.

Anyway thx for correcting.

Thank you for your work. Translators are not perfect especially for Asian languages... and do use wrong / disunified 'voices' and unnecessary 'honorific forms' (for a retro program that seldom use it) for Japanese...

@@ -222,7 +222,7 @@ BEGIN
IDS_MOUSECONFIRM, "マウス操作の確認" /* 32 */
IDS_COPYMOUSECONFIRM, "選択しているファイルまたはディレクトリーを %s にコピーしますか?"
IDS_MOVEMOUSECONFIRM, "選択しているファイルまたはディレクトリーを %s に移動しますか?"
IDS_LINKMOUSECONFIRM, "選択したファイルまたはディレクトリを % sにリンクしてもよろしいですか?"
IDS_LINKMOUSECONFIRM, "選択したファイルまたはディレクトリを %s にリンクしてもよろしいですか?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

選択しているファイルまたはディレクトリーを %s にリンクしますか?

IDS_VERBS + FUNC_LINK "ファイルマネージャはシンボリックリンク %s を作成できません: %s"
IDS_VERBS + FUNC_HARD "ファイルマネージャはハードリンク %s を作成できません: %s"
IDS_VERBS + FUNC_JUNC "ファイルマネージャはジャンクション %s を作成できません: %s"
IDS_VERBS + FUNC_LINK "ファイル マネージャーはシンボリックリンク %s を作成できません: %s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル マネージャーは %s のシンボリックリンクを作成できません: %s? Not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. But I wonder why and when these full width 's came into this file...

This was me, when I introduced symlink creation recently. Google translate gave this to me.
Anyway thx for correcting.

Thank you for your work. Translators are not perfect especially for Asian languages... and do use wrong / disunified 'voices' and unnecessary 'honorific forms' (for a retro program that seldom use it) for Japanese...

It would be great if you could ahead of merge to master also check the few translations in #352.
Are they fine?

Copy link
Contributor

@clzls clzls Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could ahead of merge to master also check the few translations in #352. Are they fine?

@schinagl I do left my reviews about them, but sorry I don't speak Japanese either (still a beginner), it may be better if a native speaker could inspect them...

Takym added a commit to Takym/winfile that referenced this pull request Nov 16, 2022
@tokomio-sun
Copy link
Contributor Author

I will close this PR, because merged into #272.

@tokomio-sun tokomio-sun deleted the fix-dialog-text-(Creating-symbolic-on-japanese-environment)) branch November 18, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants