Make async function actually async #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
approved these changes
Jan 22, 2025
yao-msft
approved these changes
Jan 22, 2025
8 tasks
zadjii-msft
added a commit
to zadjii-msft/PowerToys
that referenced
this pull request
Jan 24, 2025
_targets #355_, which I need for improvements to messages * [x] The initial package load takes a long time. This is pretty much unavoidable, but we do it on cmdpal startup, so anything after about 12s should be snappy * [x] I cannot for the life of me get `FindPackagesAsync`, to be async. The call always ends up running synchronously, so I can't hook up the `operation.Completed` event, nor the cancellation. The action is already complete! - this is probably blocking, because we still end up doing a search on most keystrokes, so we only get the final results after all the intermediate ones are done. - Just pasting a search though? Just as snappy as you'd hope. - Ahahahaha it wasn't me: [microsoft/winget-cli#5151](microsoft/winget-cli#5151) - ✅ manually wrapping this in a BG thread made it better * [ ] We probably shouldn't make the default action for an installed package "Uninstall". - Probably want to shunt over to the Settings app for the package - We probably want to do the thing where the second command doesn't show up if it's a separator - Punt? punt * [x] We need to add more metadata in the details for packages. We have it, if only we could show it: #95 - This will be a follow-up * [ ] This needs localization too * I'm using the `1.10-preview` of the winget com interfaces. On my framework laptop at least, the `RefreshPackageCatalogAsync` API isn't yet implemented, so I need to test that * [x] I don't think we implemented `MoreCommands` being observable in the host yet. We should. - Punted, #360 * [ ] I probably also need to check if other APIs we're using exist or not * [x] I haven't tested situations that like, need you to accept a license? Installing `nano` and the NanoLeaf app both _just work_. - Punted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Move to a background thread when running
FindPackagesAsyncto make it actually asynchronous.Microsoft Reviewers: Open in CodeFlow