Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build As DLL, Use Swift 6.1 prelease, on Windows #652

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Build As DLL, Use Swift 6.1 prelease, on Windows #652

merged 5 commits into from
Jan 24, 2025

Conversation

samdeane
Copy link
Contributor

@samdeane samdeane commented Jan 23, 2025 •
edited
Loading

Contains the following changes:

  • brings Windows into line with the other platforms by building SwiftGodot as a shared library
  • updates the Xcode/Swift versions in the CI workflow
  • removes a workaround for the Generator plugin on Windows, which no longer seems to be necessary when building with Swift 6.1.

@samdeane samdeane force-pushed the windows-generator-fix branch from 6470177 to e987feb Compare January 23, 2025 17:21
@samdeane samdeane force-pushed the windows-generator-fix branch from 3fcc077 to cad837a Compare January 23, 2025 17:55
@samdeane samdeane force-pushed the windows-generator-fix branch from cad837a to b6b68ac Compare January 23, 2025 17:57
@samdeane samdeane mentioned this pull request Jan 24, 2025
Merged
@samdeane samdeane changed the title Windows Swift 6.1 Fix Build As DLL, Use Swift 6.1 prelease, on Windows Jan 24, 2025
@migueldeicaza migueldeicaza merged commit 129834e into migueldeicaza:main Jan 24, 2025
2 checks passed
@samdeane samdeane deleted the windows-generator-fix branch January 27, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samdeane @migueldeicaza