[SARC-327] Implémenter les alertes : Proportion des jobs avec GPU-type sur un noeud donné plus bas qu'un threshold X #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sur un noeud donné plus bas qu'un threshold X
nurbal
reviewed
Sep 5, 2024
| nb_tasks = row.task_ | ||
| gpu_usage = row.gpu_usage_ | ||
| if gpu_usage < threshold and ( | ||
| cluster_name == "mila" or nb_tasks >= min_drac_tasks |
There was a problem hiding this comment.
ça répond bien à la définition de la tâche, néanmoins le fait de hardcoder le nom du cluster "mila" dans le code comme ça me gène un peu.
Bien que je ne vois pas comment le faire proprement via les fichiers de config non plus... une idée ?
There was a problem hiding this comment.
peut-être remplacer min_drac_taskspar min_tasks et un paramètre ignore_min_tasks_for_clusters : Optional(list(str)) = ['mila'] ? comme ça on ne met plus les références à Mila ou DRAC dans le code, mais on les déplace dans les paramètres par défaut... qu'en penses-tu ?
There was a problem hiding this comment.
Après ça ce sera bon pour moi
…eck_gpu_type_usage_per_node()`
nurbal
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nurbal