Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not enable rate limiter for restful v1 #39553

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Jan 23, 2025

issue: #39556

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 23, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (4cf268b) to head (8c15159).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v1.go 0.00% 0 Missing and 6 partials ⚠️
internal/distributed/proxy/httpserver/utils.go 40.00% 2 Missing and 1 partial ⚠️
internal/proxy/rate_limit_interceptor.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39553       +/-   ##
===========================================
+ Coverage   69.56%   80.94%   +11.38%     
===========================================
  Files         300     1408     +1108     
  Lines       26985   198893   +171908     
===========================================
+ Hits        18772   160997   +142225     
- Misses       8213    32195    +23982     
- Partials        0     5701     +5701     
Components Coverage Δ
Client 79.51% <ø> (∅)
Core 69.56% <ø> (ø)
Go 82.86% <50.00%> (∅)
Files with missing lines Coverage Δ
internal/proxy/util.go 89.32% <100.00%> (ø)
internal/distributed/proxy/httpserver/utils.go 84.61% <40.00%> (ø)
internal/proxy/rate_limit_interceptor.go 89.61% <40.00%> (ø)
...nternal/distributed/proxy/httpserver/handler_v1.go 88.50% <0.00%> (ø)

... and 1104 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 24, 2025
@mergify mergify bot added the ci-passed label Jan 24, 2025
sre-ci-robot pushed a commit that referenced this pull request Jan 24, 2025
issue: #39556 
pr: #39553 
2.5: #39555

Signed-off-by: lixinguo <[email protected]>
Co-authored-by: lixinguo <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Jan 24, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 47d280d into milvus-io:master Jan 24, 2025
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants