Fixed issue fields and some tests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gizdatullin
reviewed
Oct 31, 2024
| return new UserShortInfo | ||
| { | ||
| Display = element.GetProperty("display").GetString() ?? string.Empty, | ||
| Id = element.GetProperty("id").GetString() ?? string.Empty | ||
| Display = display ?? throw new ArgumentNullException(display), |
There was a problem hiding this comment.
А точно исключение кидать надо? Эти оба поля обязательные?
There was a problem hiding this comment.
Плюс там еще ниже есть точно такой же кейс. ToFieldInfoCollection например.
There was a problem hiding this comment.
поля обязательные. Второй кейс поправил, там только поле Key необязательное
gizdatullin
reviewed
Oct 31, 2024
Comment on lines
61
to
63
| Id = display ?? throw new ArgumentNullException(display), | ||
| Key = item.GetProperty("key").GetString(), | ||
| Display = id ?? throw new ArgumentNullException(id) |
There was a problem hiding this comment.
display и id местами перепутано.
gizdatullin
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.