Fixed issue fields and some tests

Directory.Build.props

@@ -14,7 +14,7 @@
   </PropertyGroup>
   <PropertyGroup>
     <VersionMajor>2</VersionMajor>
-    <VersionMinor>0</VersionMinor>
+    <VersionMinor>1</VersionMinor>
     <BuildNumber>$(BuildNumber)</BuildNumber>
     <BuildNumber Condition="'$(BuildNumber)' == ''">0</BuildNumber>
     <PackageVersion>$(VersionMajor).$(VersionMinor).$(BuildNumber)$(VersionTag)</PackageVersion>

Mindbox.YandexTracker.Abstractions/Entities/IssueField.cs

@@ -1,4 +1,5 @@
 using System.Collections.ObjectModel;
+using System.Text.Json;
 
 namespace Mindbox.YandexTracker;
 
@@ -92,5 +93,5 @@ public sealed record OptionsProviderInfo
 	/// <summary>
 	/// Массив со значениями поля
 	/// </summary>
-	public Collection<object> Values { get; init; } = [];
+	public Collection<JsonElement> Values { get; init; } = [];
 }

Mindbox.YandexTracker.Abstractions/Entities/Project.cs

@@ -61,38 +61,38 @@ public sealed record Project
 	/// <summary>
 	/// Участники проекта
 	/// </summary>
-	public Collection<UserShortInfo>? TeamUsers { get; init; }
+	public Collection<UserShortInfo> TeamUsers { get; init; } = [];
 
 	/// <summary>
 	/// Заказчики
 	/// </summary>
-	public Collection<UserShortInfo>? Clients { get; init; }
+	public Collection<UserShortInfo> Clients { get; init; } = [];
 
 	/// <summary>
 	/// Наблюдатели
 	/// </summary>
-	public Collection<UserShortInfo>? Followers { get; init; }
+	public Collection<UserShortInfo> Followers { get; init; } = [];
 
 	/// <summary>
 	/// Теги
 	/// </summary>
-	public Collection<string>? Tags { get; init; }
+	public Collection<string> Tags { get; init; } = [];
 
 	/// <summary>
 	/// Дата начала
 	/// </summary>
 	/// <remarks>
 	/// Учитывается только год, месяц и день
 	/// </remarks>
-	public DateTime? StartUtc { get; init; }
+	public DateOnly? StartUtc { get; init; }
 
 	/// <summary>
 	/// Дедлайн
 	/// </summary>
 	/// <remarks>
 	/// Учитывается только год, месяц и день
 	/// </remarks>
-	public DateTime? EndUtc { get; init; }
+	public DateOnly? EndUtc { get; init; }
 
 	/// <summary>
 	/// Доступ
@@ -107,12 +107,12 @@ public sealed record Project
 	/// <summary>
 	/// Кварталы начала и окончания проекта
 	/// </summary>
-	public Collection<string>? Quarter { get; init; }
+	public Collection<string> Quarter { get; init; } = [];
 
 	/// <summary>
 	/// Идентификаторы чеклистов
 	/// </summary>
-	public Collection<string>? ChecklistIds { get; init; }
+	public Collection<string> ChecklistIds { get; init; } = [];
 
 	/// <summary>
 	/// Идентификатор родительского проекта
@@ -123,7 +123,7 @@ public sealed record Project
 	/// Очереди задач, содержащихся в проекте
 	/// </summary>
 	/// <returns></returns>
-	public Collection<string>? IssueQueueKeys { get; init; }
+	public Collection<string> IssueQueueKeys { get; init; } = [];
 
 	public override int GetHashCode()
 	{

Mindbox.YandexTracker.Abstractions/Entities/UserDetailedInfo.cs

@@ -10,7 +10,7 @@ public sealed record UserDetailedInfo
 	/// <summary>
 	/// Уникальный идентификатор учетной записи пользователя в Tracker
 	/// </summary>
-	public required long Id { get; init; }
+	public required long Uid { get; init; }
 
 	/// <summary>
 	/// Логин пользователя

Mindbox.YandexTracker.Tests/IntegrationsTests/YandexTrackerClientTests.cs

@@ -45,10 +45,37 @@ public async Task GetQueuesAsync_ResponseInNotNullAndContainsSomeQueues()
 	public async Task GetIssueAsync_IssueKey_ResponseIsNotNullAndIssueSuccessfullyCreated()
 	{
 		// Arrange
+
+		var currentUserShortInfo = new UserShortInfo
+		{
+			Display = CurrentUserLogin,
+			Id = CurrentUserId
+		};
+
+		var nowUtc = DateTime.UtcNow;
+		var dateTimeOnlyStart = DateOnly.FromDateTime(nowUtc);
+		var tags = new[] { "tag1", "tag2" };
+		var summary = GetUniqueName();
+
 		var issue = await YandexTrackerClient.CreateIssueAsync(new Issue
 		{
 			QueueKey = TestQueueKey,
-			Summary = GetUniqueName()
+			Summary = summary,
+			CreatedBy = currentUserShortInfo,
+			Description = "DESC",
+			Tags = tags,
+			Followers = [currentUserShortInfo],
+			Assignee = currentUserShortInfo,
+			Author = currentUserShortInfo,
+			Priority = Priority.Trivial,
+			Start = dateTimeOnlyStart,
+			Type = new IssueType
+			{
+				Id = 2,
+				Name = "Задача",
+				Key = "task"
+			},
+			UpdatedBy = currentUserShortInfo
 		});
 
 		// Act
@@ -57,6 +84,18 @@ public async Task GetIssueAsync_IssueKey_ResponseIsNotNullAndIssueSuccessfullyCr
 		// Arrange
 		Assert.IsNotNull(issue);
 		Assert.AreEqual(issue.Key, issueResponse.Key);
+		Assert.AreEqual(summary, issueResponse.Summary);
+		Assert.AreEqual(dateTimeOnlyStart, issueResponse.Start);
+		Assert.AreEqual("task", issueResponse.Type.Key);
+		Assert.AreEqual("DESC", issueResponse.Description);
+		Assert.AreEqual(Priority.Trivial, issueResponse.Priority);
+		Assert.AreEqual(currentUserShortInfo.Id, issueResponse.CreatedBy.Id);
+		Assert.AreEqual(currentUserShortInfo.Id, issueResponse.UpdatedBy.Id);
+		Assert.AreEqual(currentUserShortInfo.Id, issueResponse.Assignee!.Id);
+		Assert.AreEqual(1, issueResponse.Followers.Count);
+		Assert.AreEqual(currentUserShortInfo.Id, issueResponse.Followers.First().Id);
+		Assert.AreEqual(2, issueResponse.Tags.Count);
+		CollectionAssert.AreEqual(tags, issueResponse.Tags.ToList());
 	}
 
 	[TestMethod]
@@ -408,10 +447,12 @@ public async Task GetProjectsAsync_Project_ProjectFields_ResponseIsNotNullAndCon
 		};
 
 		var nowUtc = DateTime.UtcNow;
-		var endUtc = nowUtc.AddDays(3);
 		var tags = new Collection<string> { "tag1", "tag2" };
 		var quarter = new Collection<string>();
 
+		var dateOnlyNow = DateOnly.FromDateTime(nowUtc);
+		var dateOnlyEnd = DateOnly.FromDateTime(nowUtc.AddDays(3));
+
 		var project1 = await YandexTrackerClient.CreateProjectAsync(
 			ProjectEntityType.Project,
 			new Project
@@ -424,8 +465,8 @@ public async Task GetProjectsAsync_Project_ProjectFields_ResponseIsNotNullAndCon
 				Description = "DESC",
 				Tags = tags,
 				ProjectType = ProjectEntityType.Project,
-				StartUtc = nowUtc,
-				EndUtc = endUtc,
+				StartUtc = dateOnlyNow,
+				EndUtc = dateOnlyEnd,
 				CreatedBy = currentUserShortInfo,
 				TeamAccess = false,
 				TeamUsers = [currentUserShortInfo],
@@ -479,12 +520,8 @@ public async Task GetProjectsAsync_Project_ProjectFields_ResponseIsNotNullAndCon
 		CollectionAssert.AreEqual(tags, actualProject.Tags);
 		Assert.AreEqual(ProjectEntityType.Project, actualProject.ProjectType);
 		Assert.AreEqual(ProjectEntityStatus.InProgress, actualProject.Status);
-		Assert.IsTrue(nowUtc.Year == actualProject.StartUtc?.Year // Возвращается только год, месяц и день
-		    && nowUtc.Month == actualProject.StartUtc?.Month
-		    && nowUtc.Day == actualProject.StartUtc?.Day);
-		Assert.IsTrue(endUtc.Year == actualProject.EndUtc?.Year // Возвращается только год, месяц и день
-			&& endUtc.Month == actualProject.EndUtc?.Month
-			&& endUtc.Day == actualProject.EndUtc?.Day);
+		Assert.AreEqual(dateOnlyNow, actualProject.StartUtc);
+		Assert.AreEqual(dateOnlyEnd, actualProject.EndUtc);
 		Assert.AreEqual(currentUserShortInfo.Id, actualProject.CreatedBy.Id);
 		Assert.IsNull(actualProject.TeamAccess);
 		Assert.AreEqual(1, actualProject.TeamUsers!.Count);

Mindbox.YandexTracker.Tests/UnitTests/HashCodeTests.cs

@@ -110,7 +110,7 @@ public void GetHashCode_TwoSimilarProjects_HashCodeShouldBeEqual()
 				Id = authorUserId,
 				Display = "displayw"
 			},
-			EndUtc = future.AddDays(-3),
+			EndUtc = DateOnly.FromDateTime(future.AddDays(-3)),
 			Lead = new UserShortInfo
 			{
 				Id = authorUserId,
@@ -119,7 +119,7 @@ public void GetHashCode_TwoSimilarProjects_HashCodeShouldBeEqual()
 			Quarter = ["q1", "q2"],
 			ParentId = 3,
 			Description = "project for project",
-			StartUtc = future.AddDays(2),
+			StartUtc = DateOnly.FromDateTime(future.AddDays(2)),
 			Status = ProjectEntityStatus.Draft,
 			Summary = "summary",
 			ShortId = 2
@@ -147,7 +147,7 @@ public void GetHashCode_TwoSimilarProjects_HashCodeShouldBeEqual()
 				Id = authorUserId,
 				Display = "displayw"
 			},
-			EndUtc = future.AddDays(-3),
+			EndUtc = DateOnly.FromDateTime(future.AddDays(-3)),
 			Lead = new UserShortInfo
 			{
 				Id = authorUserId,
@@ -156,7 +156,7 @@ public void GetHashCode_TwoSimilarProjects_HashCodeShouldBeEqual()
 			Quarter = ["q1", "q2"],
 			ParentId = 3,
 			Description = "project for project",
-			StartUtc = future.AddDays(2),
+			StartUtc = DateOnly.FromDateTime(future.AddDays(2)),
 			Status = ProjectEntityStatus.Draft,
 			Summary = "summary",
 			ShortId = 2

Mindbox.YandexTracker.Tests/YandexTrackerTestBase.cs

@@ -36,7 +36,7 @@ public static async Task TestInitializeAsync(TestContext context)
 
 		// узнаем инфу о пользователи, от имени которого выполняем запрос
 		var userInfo = await YandexTrackerClient.GetMyselfAsync();
-		CurrentUserId = userInfo.Id.ToString(CultureInfo.InvariantCulture);
+		CurrentUserId = userInfo.Uid.ToString(CultureInfo.InvariantCulture);
 		CurrentUserLogin = userInfo.Login;
 
 		// в ключе может быть до 15 латинских символов

Mindbox.YandexTracker/Dtos/Requests/Create/CreateIssueRequest.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Text.Json;
@@ -19,6 +20,8 @@ internal sealed record CreateIssueRequest
 
 	public string? Parent { get; init; }
 
+	public DateOnly? Start { get; init; }
+
 	public string? Author { get; init; }
 
 	public string? Unique { get; init; }

Mindbox.YandexTracker/Dtos/Requests/Create/CreateProjectRequest.cs

@@ -33,12 +33,12 @@ internal sealed record ProjectFieldsDto
 	/// <remarks>
 	/// Must have YYYY-MM-DDThh:mm:ss.sss±hhmm format
 	/// </remarks>
-	public DateTime? Start { get; init; }
+	public DateOnly? Start { get; init; }
 
 	/// <remarks>
 	/// Must have YYYY-MM-DDThh:mm:ss.sss±hhmm format
 	/// </remarks>
-	public DateTime? End { get; init; }
+	public DateOnly? End { get; init; }
 
 	public Collection<string>? Tags { get; init; }
 

Mindbox.YandexTracker/Dtos/Responses/Create/CreateIssueResponse.cs

@@ -20,6 +20,8 @@ internal sealed record CreateIssueResponse
 
 	public required FieldInfo UpdatedBy { get; init; }
 
+	public FieldInfo? Author { get; init; }
+
 	public string? Description { get; init; }
 
 	[JsonPropertyName("sprint")]

Mindbox.YandexTracker/Dtos/Responses/Read/GetIssueFieldsResponse.cs

@@ -1,4 +1,5 @@
 using System.Collections.ObjectModel;
+using System.Text.Json;
 
 namespace Mindbox.YandexTracker;
 
@@ -10,6 +11,8 @@ internal sealed record GetIssueFieldsResponse
 
 	public required string Name { get; init; }
 
+	public string? Description { get; init; }
+
 	public bool Readonly { get; init; }
 
 	public bool Options { get; init; }
@@ -49,5 +52,5 @@ internal class OptionsProviderInfoDto
 {
 	public required string Type { get; init; }
 
-	public Collection<object> Values { get; init; } = [];
+	public Collection<JsonElement> Values { get; init; } = [];
 }

Mindbox.YandexTracker/Dtos/Responses/Read/GetIssueResponse.cs

@@ -29,6 +29,8 @@ internal sealed record GetIssueResponse
 
 	public required FieldInfo Type { get; init; }
 
+	public FieldInfo? Author { get; init; }
+
 	public required FieldInfo Priority { get; init; }
 
 	public DateTime CreatedAt { get; init; }
@@ -51,7 +53,7 @@ internal sealed record GetIssueResponse
 
 	public FieldInfo? PreviousStatus { get; init; }
 
-	public bool IsFavorite { get; init; }
+	public bool Favorite { get; init; }
 
 	public DateOnly? Start { get; set; }
 

Mindbox.YandexTracker/Extensions/JsonElementExtensions.cs

@@ -1,4 +1,5 @@
-using System.Collections.ObjectModel;
+using System;
+using System.Collections.ObjectModel;
 using System.Text.Json;
 
 namespace Mindbox.YandexTracker;
@@ -7,10 +8,13 @@ internal static class JsonElementExtensions
 {
 	public static UserShortInfo ToUserShortInfo(this JsonElement element)
 	{
+		var display = element.GetProperty("display").GetString();
+		var id = element.GetProperty("id").GetString();
+
 		return new UserShortInfo
 		{
-			Display = element.GetProperty("display").GetString() ?? string.Empty,
-			Id = element.GetProperty("id").GetString() ?? string.Empty
+			Display = display ?? throw new ArgumentNullException(display),
+			Id = id ?? throw new ArgumentNullException(id)
 		};
 	}
 
@@ -49,11 +53,14 @@ public static Collection<FieldInfo> ToFieldInfoCollection(this JsonElement eleme
 
 		foreach (var item in element.EnumerateArray())
 		{
+			var display = item.GetProperty("display").GetString();
+			var id = item.GetProperty("id").GetString();
+
 			collection.Add(new FieldInfo
 			{
-				Id = item.GetProperty("id").GetString() ?? string.Empty,
-				Key = item.GetProperty("key").GetString() ?? string.Empty,
-				Display = item.GetProperty("display").GetString() ?? string.Empty
+				Id = id ?? throw new ArgumentNullException(id),
+				Key = item.GetProperty("key").GetString(),
+				Display = display ?? throw new ArgumentNullException(display)
 			});
 		}