Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Request]: space #83

Closed
Lazerbeak12345 opened this issue Apr 4, 2022 · 1 comment
Closed

[Mod Request]: space #83

Lazerbeak12345 opened this issue Apr 4, 2022 · 1 comment
Labels
breaks-rule1 This mod currently takes over the game. breaks-rule3 This mod currently destroys the world (read: player's work) breaks-rule9 This mod is currently incompatible with other whynot mods. mapgen New mod proposal affects mapgen new-mod-proposal Consider the mod can be applied to the game

Comments

@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Apr 4, 2022

Request

This is the URL for the mod I would like to be added:

https://forum.minetest.net/viewtopic.php?t=14497

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
  • It does tons of mapgen stuff that seems risky. Assuming it only does this in unloaded chunks that might be fine, but I'd like to both test it and see the code.
  1. When could this mod be a strain on the server when no players are using the mod?
  • I don't think it would. UNTESTED
  1. When does this mod destroy player's work?
  • Sounds like great effort was made to prevent this from happening automatically. There's a mod tool to make asteroids - sounds like it might do this sometimes. UNTESTED
  1. Have you looked at the code? If so, what stood out as things that might need fixing?
  • No. THIS NEEDS DONE.
  1. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
  • Perhaps with it's biomes or whatever it could be split? I don't think it needs it. UNTESTED
  1. Is this mod survival freindly? What items that it provides that should be craftable/obtainable, but arent?
  • Sounds good. UNTESTED
  1. When does this mod feel like cheating?
  • UNTESTED
  1. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
  • Yes.
  1. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?

Other comments

No forum updates since 2016. Could be really out of date.

THIS NEEDS TESTED. I'm just splitting this mod from #32

@Lazerbeak12345 Lazerbeak12345 added new-mod-proposal Consider the mod can be applied to the game mapgen New mod proposal affects mapgen breaks-rule1 This mod currently takes over the game. breaks-rule3 This mod currently destroys the world (read: player's work) breaks-rule9 This mod is currently incompatible with other whynot mods. labels Apr 4, 2022
@Lazerbeak12345 Lazerbeak12345 mentioned this issue Apr 5, 2022
4 tasks
@dacmot
Copy link
Collaborator

dacmot commented Apr 6, 2022

I would rule this one out since it may have a unfixed crash and is unmaintained. It does seem cool though, and could maybe work in the future for the idea of realms. Just not in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-rule1 This mod currently takes over the game. breaks-rule3 This mod currently destroys the world (read: player's work) breaks-rule9 This mod is currently incompatible with other whynot mods. mapgen New mod proposal affects mapgen new-mod-proposal Consider the mod can be applied to the game
Projects
None yet
Development

No branches or pull requests

2 participants