Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the register app form #1228

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Conversation

michaeljcollinsuk
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk commented Dec 7, 2023

Relates to ministryofjustice/analytical-platform#2633

📝 Summary

Post-migration app migration we want to make registering apps self service, therefore the app registration form has been simplified and opened to all logged in users.

This PR:

  • Reduces the app registration form to a repo url and datasource.
  • Improves validation and error handling when registering an app
  • Remove unnecessary JS when looking up a repo, and limiting repos to the ministryofjustice org
  • Only an AWS role is created for the app, other settings and Auth0 clients will be created via the manage app page
  • Create cloud platform assume role policy when creating app AWS Role

🔍 What should the reviewer concentrate on?

  • Changes to the app registration flow

🧑‍💻 How should the reviewer test these changes?

📚 Documentation status

Only ask for a repo URL and datasource when registering an app.
This is because the form will now be publically accessible,
with a new flow for creating auth0 clients. Also removes JS to
lookup repositories, as this is no longer needed.
@michaeljcollinsuk michaeljcollinsuk force-pushed the feature/app-registration-form branch from 5c4e7c7 to 0160cc3 Compare January 9, 2024 15:32
Adds statement to allow cloud platform to assume the app IAM role
App registration form should be open to logged in users, to help
enable self service of app registration. Updating connections
remains superuser only.
@michaeljcollinsuk michaeljcollinsuk marked this pull request as ready for review January 15, 2024 15:12
Copy link

@mitchdawson1982 mitchdawson1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk merged commit 1ebe547 into main Jan 30, 2024
5 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the feature/app-registration-form branch January 30, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔄 Update Control Panel Process for App Creation Post-Migration
2 participants