-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the register app form #1228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Only ask for a repo URL and datasource when registering an app. This is because the form will now be publically accessible, with a new flow for creating auth0 clients. Also removes JS to lookup repositories, as this is no longer needed.
michaeljcollinsuk
force-pushed
the
feature/app-registration-form
branch
from
January 9, 2024 15:32
5c4e7c7
to
0160cc3
Compare
Adds statement to allow cloud platform to assume the app IAM role
App registration form should be open to logged in users, to help enable self service of app registration. Updating connections remains superuser only.
mitchdawson1982
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to ministryofjustice/analytical-platform#2633
📝 Summary
Post-migration app migration we want to make registering apps self service, therefore the app registration form has been simplified and opened to all logged in users.
This PR:
ministryofjustice
org🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
pytest tests
📚 Documentation status