PI-2657 Set UPW reminder schedule to 10am

Also remove unused dryRun flag.
ministryofjustice · Nov 25, 2024 · 2a291e6 · 2a291e6
1 parent 2aff051
commit 2a291e6
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 13 deletions.
diff --git a/...tment-reminders-and-delius/deploy/templates/unpaid-work-appointment-reminders-cronjob.yml b/...tment-reminders-and-delius/deploy/templates/unpaid-work-appointment-reminders-cronjob.yml
@@ -42,6 +42,4 @@ spec:
                   value: "true"
                 - name: JOBS_UNPAID-WORK-APPOINTMENT-REMINDERS_PROVIDER
                   value: "N56"
-                - name: JOBS_UNPAID-WORK-APPOINTMENT-REMINDERS_DRY-RUN
-                  value: "{{ index .Values "jobs" "unpaid-work-appointment-reminders" "dry-run" }}"
           restartPolicy: Never
diff --git a/projects/appointment-reminders-and-delius/deploy/values-dev.yml b/projects/appointment-reminders-and-delius/deploy/values-dev.yml
@@ -16,5 +16,4 @@ generic-prometheus-alerts:
 
 jobs:
   unpaid-work-appointment-reminders:
-    dry-run: false
-    schedule: '0 18 * * *' # 6:00pm UTC every day
+    schedule: '0 10 * * *' # 10am UTC every day
diff --git a/projects/appointment-reminders-and-delius/deploy/values-preprod.yml b/projects/appointment-reminders-and-delius/deploy/values-preprod.yml
@@ -15,5 +15,4 @@ generic-prometheus-alerts:
 
 jobs:
   unpaid-work-appointment-reminders:
-    dry-run: false
-    schedule: '0 18 * * *' # 6:00pm UTC every day
+    schedule: '0 10 * * *' # 10am UTC every day
diff --git a/projects/appointment-reminders-and-delius/deploy/values-prod.yml b/projects/appointment-reminders-and-delius/deploy/values-prod.yml
@@ -10,5 +10,4 @@ generic-service:
 
 jobs:
   unpaid-work-appointment-reminders:
-    dry-run: true
-    schedule: '30 18 * * *' # 6:30pm UTC every day
+    schedule: '0 10 * * *' # 10am UTC every day
diff --git a/...delius/src/main/kotlin/uk/gov/justice/digital/hmpps/cronjob/UpwAppointmentRemindersJob.kt b/...delius/src/main/kotlin/uk/gov/justice/digital/hmpps/cronjob/UpwAppointmentRemindersJob.kt
@@ -15,13 +15,11 @@ import kotlin.system.exitProcess
 class UpwAppointmentRemindersJob(
     @Value("\${jobs.unpaid-work-appointment-reminders.provider}")
     private val providerCode: String,
-    @Value("\${jobs.unpaid-work-appointment-reminders.dry-run:false}")
-    private val dryRun: Boolean,
     private val service: UnpaidWorkAppointmentsService,
     private val applicationContext: ApplicationContext,
 ) : ApplicationListener<ApplicationStartedEvent> {
     override fun onApplicationEvent(applicationStartedEvent: ApplicationStartedEvent) {
-        service.sendUnpaidWorkAppointmentReminders(providerCode, dryRun)
+        service.sendUnpaidWorkAppointmentReminders(providerCode)
         exitProcess(exit(applicationContext, { 0 }))
     }
 }
diff --git a/...ius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/UnpaidWorkAppointmentsService.kt b/...ius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/UnpaidWorkAppointmentsService.kt
@@ -14,8 +14,8 @@ class UnpaidWorkAppointmentsService(
     private val telemetryService: TelemetryService,
     @Value("\${govuk-notify.templates.upw-appointment-reminder}") private val templateId: String,
 ) {
-    fun sendUnpaidWorkAppointmentReminders(providerCode: String, dryRun: Boolean = false) {
-        upwAppointmentRepository.getUnpaidWorkAppointments(LocalDate.now().plusDays(3), providerCode)
+    fun sendUnpaidWorkAppointmentReminders(providerCode: String) {
+        upwAppointmentRepository.getUnpaidWorkAppointments(LocalDate.now().plusDays(2), providerCode)
             .forEach {
                 notificationClient.sendSms(
                     templateId,