Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El 1706 remove session reset #1570

Merged
merged 2 commits into from
Oct 4, 2024
Merged

El 1706 remove session reset #1570

merged 2 commits into from
Oct 4, 2024

Conversation

willc-work
Copy link
Contributor

Jira ticket

What changed and why

remove the session_reset command as it was not achieving its intended aim

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

Copy link
Contributor

@MazOneTwoOne MazOneTwoOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this reverses the changes from EL-1660.

I guess we won't need to UAT i.e. have portal point to our UAT file etc.

@willc-work
Copy link
Contributor Author

Approving as this reverses the changes from EL-1660.

I guess we won't need to UAT i.e. have portal point to our UAT file etc.

it only reverts part of the el-1660, the portal changes will remain in place it was just the session_reset that we no longer need

@willc-work willc-work merged commit 4671314 into main Oct 4, 2024
12 checks passed
@willc-work willc-work deleted the EL-1706-rm-session-reset branch October 4, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants